Beats CM now handle the new response format from Kibana. #11377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph
commented
Mar 21, 2019
| INTEGRATION_TESTS = os.environ.get('INTEGRATION_TESTS', False) | ||
| # Disable because waiting artifacts from https://github.com/elastic/kibana/pull/31660 | ||
| # INTEGRATION_TESTS = os.environ.get('INTEGRATION_TESTS', False) | ||
| INTEGRATION_TESTS = False |
There was a problem hiding this comment.
chicken-egg, we need snapshots of Kibana and ES to have the integration suite working. So I am disabling it.
Format is defined in elastic/kibana#27408 Main objective is to easier bubbling or errors and messages. ``` export interface ReturnType { error?: { message: string; code?: number; }; success: boolean; } ```
ph
force-pushed
the
cm/better-error-resposne-from-kibana
branch
from
ccc8f67 to
a1784cb
Compare
ph
commented
Mar 27, 2019
| Error ErrorResponse `json:"error,omitempty"` | ||
| } | ||
|
|
||
| // ErrorResponse contains human reable and machine readable information when an error happen. |
There was a problem hiding this comment.
replace with ErrorResponse contains human readable and machine readable information when an error happens.
urso
approved these changes
Mar 27, 2019
|
rebased+typo, waiting on green to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format is defined in elastic/kibana#27408
Main objective is to easier bubbling or errors and messages.