Remove godox and add exclude rule for forbidigo (#31433)

elastic · Apr 27, 2022 · 4782290 · 4782290
1 parent aa47590
commit 4782290
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -21,6 +21,9 @@ issues:
     - linters:
         - stylecheck
       text: "ST1003:"
+    # From mage we are priting to the console to ourselves
+    - path: (.*magefile.go|.*dev-tools/mage/.*)
+      linters: forbidigo
 
 output:
   sort-results: true
@@ -68,7 +71,6 @@ linters:
     - noctx # noctx finds sending http request without context.Context
     - unconvert # Remove unnecessary type conversions
     - wastedassign # wastedassign finds wasted assignment statements.
-    - godox # tool for detection of FIXME, TODO and other comment keywords
     - gomodguard # check for blocked dependencies
 
 # all available settings of specific linters

diff --git a/dev-tools/templates/.golangci.yml b/dev-tools/templates/.golangci.yml
@@ -18,6 +18,9 @@ issues:
     - text: "ST1003:"
       linters:
         - stylecheck
+    # From mage we are priting to the console to ourselves
+    - path: (.*magefile.go|.*dev-tools/mage/.*)
+      linters: forbidigo
 
 output:
   sort-results: true
@@ -65,7 +68,6 @@ linters:
     - noctx # noctx finds sending http request without context.Context
     - unconvert # Remove unnecessary type conversions
     - wastedassign # wastedassign finds wasted assignment statements.
-    - godox # tool for detection of FIXME, TODO and other comment keywords
     - gomodguard # check for blocked dependencies
 
 # all available settings of specific linters