Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wildcard matcher tests #313

Merged
merged 5 commits into from
Aug 17, 2020

Conversation

felixbarny
Copy link
Member

This extracts some of the wildcard matcher tests from the Java agent to a format that should be verified by all agents when implementing the wildcard matcher for #144

@mikker mikker self-requested a review August 11, 2020 20:32
@felixbarny
Copy link
Member Author

@elastic/observablt-robots could you set up automation, similar to the one for the gherkin-specs folder, that syncs up the json-specs folder to the agent repos by creating PRs?

@felixbarny
Copy link
Member Author

felixbarny commented Aug 12, 2020

Dear @elastic/apm-agent-devs

Please specify in which directory you want the json-specs folder to be synced to.

Agent Path
.NET
Go internal/testdata/json-specs
Java apm-agent-core/src/test/resources/json-specs
Node.js
PHP tests/APM_Agents_shared/json-specs
Python tests/upstream/json-specs
Ruby spec/fixtures/

This is the current destination of the gherkin-specs folder: https://github.com/elastic/apm/blob/master/.ci/.jenkins-agents.yml

Add Python and Go paths

Co-authored-by: Manuel de la Peña <[email protected]>
@mdelapenya
Copy link
Contributor

Hey @felixbarny, we finished (and polished) the automation for the PRs, so I think we can merge this and manually trigger the build (see #324)

BTW, the PHP agent does not have an entry for Gherkin specs, should it be added, and implemented in the agent end?

@felixbarny
Copy link
Member Author

BTW, the PHP agent does not have an entry for Gherkin specs, should it be added, and implemented in the agent end?

The PHP agent is not GA yet. But yes, eventually also the PHP agent should be added. I've created follow up issues for .NET and PHP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants