Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle transaction_ignore_urls setting [WIP] #773

Closed
wants to merge 4 commits into from
Closed

handle transaction_ignore_urls setting [WIP] #773

wants to merge 4 commits into from

Conversation

beniwohli
Copy link
Contributor

@beniwohli beniwohli commented Mar 25, 2020 •
edited by zube bot
Loading

TODO:

  • Django tests
  • Django ASGI tests
  • Flask tests
  • aiohttp tests
  • Starlette tests
  • Tornado tests

Related issues

closes #772

@beniwohli beniwohli requested a review from basepi April 21, 2020 13:32
basepi
basepi approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. At some point we'll probably want to see if there's an elegant way to combine some of this repeated code. (Obviously DRY isn't everything, sometimes it becomes much harder to read/maintain, but it was just a thought.)

@apmmachine
Copy link
Contributor

apmmachine commented Apr 28, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-05-01T14:08:33.317+0000

  • Duration: 34 min 38 sec (2018430)

  • Commit: ee72490

Test stats 🧪

Test Results
Failed 0
Passed 9341
Skipped 6667
Total 16008

@basepi
Copy link
Contributor

basepi commented Aug 11, 2020

There is now a set of common tests that we'll need to integrate: elastic/apm#313

@beniwohli beniwohli mentioned this pull request Sep 15, 2020
Merged
@beniwohli
Copy link
Contributor Author

closing in favor of #923

@beniwohli beniwohli closed this Sep 15, 2020
@beniwohli beniwohli deleted the transaction-ignore-urls branch June 9, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basepi basepi basepi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement transaction_ignore_urls
3 participants
@beniwohli @apmmachine @basepi