Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processor/otel: deprecate service.version span tag #6131

Merged
merged 1 commit into from
Sep 8, 2021
Merged

processor/otel: deprecate service.version span tag #6131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/head.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,4 @@ https://github.com/elastic/apm-server/compare/7.13\...master[View commits]

[float]
==== Deprecated
- Setting `service.version` as a span tag (Jaeger) or attribute (OTel) is deprecated; use tracer tags (Jaeger) and resource attributes (OTel) {pull}6131[6131]
4 changes: 4 additions & 0 deletions processor/otel/traces.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,10 @@ func translateTransaction(
case "type":
event.Transaction.Type = stringval
case semconv.AttributeServiceVersion:
// NOTE support for sending service.version as a span tag
// is deprecated, and will be removed in 8.0. Instrumentation
// should set this as a resource attribute (OTel) or tracer
// tag (Jaeger).
event.Service.Version = stringval
case "component":
component = stringval
Expand Down