processor/otel: deprecate service.version span tag
#6131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
force-pushed
the
deprecate-service-version-span-attr
branch
from
4dc74b7 to
8616d1d
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
stuartnelson3
approved these changes
Sep 8, 2021
mergify bot
pushed a commit
that referenced
this pull request
Sep 8, 2021
(cherry picked from commit b6d8d64) # Conflicts: # changelogs/head.asciidoc
axw
added a commit
that referenced
this pull request
Sep 8, 2021
…6131) (#6135) * OTel: deprecate `service.version` span tag (#6131) (cherry picked from commit b6d8d64) # Conflicts: # changelogs/head.asciidoc * Delete head.asciidoc Co-authored-by: Andrew Wilkins <[email protected]>
marclop
added
backport-skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Deprecate interpreting
service.versionas a span tag. We'll remove this in 8.0, and from then on instrumentation will have to use tracer tags (Jaeger) or resource attributes (OTel).#4061 added support for setting
service.versionvia Jaeger span tags. In retrospect, we should not have done this; service version should be coming through as a tracer tag, as it applies to the service as a whole and not individual spans.Checklist
- [ ] Documentation has been updatedHow to test these changes
N/A
Related issues
#6114 (comment)