[7.14] processor/otel: record array resource attributes (backport #5704) #5716

mergify · 2021-07-15T02:20:32Z

This is an automatic backport of pull request #5704 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

@Mergifyio refresh will re-evaluate the rules
@Mergifyio rebase will rebase this PR on its base branch
@Mergifyio update will merge the base branch into this PR
@Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

look at your merge queues
generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

* processor/otel: record array resource attributes If an unhandled array attribute is found in resource attributes, store that as a label like we do with span attributes. * processor/otel: handle array attrs for spans (cherry picked from commit 4264a2a)

apmmachine · 2021-07-15T03:05:11Z

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2021-07-15T02:20:46.447+0000
Duration: 44 min 18 sec
Commit: 8831d73

Test stats 🧪

Test	Results
Failed	1
Passed	4697
Skipped	107
Total	4805

Trends 🧪

Test errors

Expand to view the tests failures

`Build and Test / APM Integration Tests / test_concurrent_req_dotnet_foobar – tests.agent.test_dotnet`

Expand to view the error details

 AssertionError: queried for [('processor.event', 'transaction'), ('service.name', ['dotnetapp', 'dotnetapp'])], expected 1375, got 1374

Expand to view the stacktrace

 dotnet = <tests.fixtures.agents.Agent object at 0x7fd676a5e550>

    @pytest.mark.version
    @pytest.mark.dotnet
    def test_concurrent_req_dotnet_foobar(dotnet):
        foo = Concurrent.Endpoint(dotnet.foo.url,
                                  dotnet.app_name,
                                  ["foo"],
                                  "GET /foo",
                                  events_no=375)
        bar = Concurrent.Endpoint(dotnet.bar.url,
                                  dotnet.app_name,
                                  ["bar", "extra"],
                                  "GET /bar")
>       Concurrent(dotnet.apm_server.elasticsearch, [foo, bar], iters=1).run()

tests/agent/test_dotnet.py:43: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests/agent/concurrent_requests.py:299: in run
    self.check_counts(it)
tests/agent/concurrent_requests.py:137: in check_counts
    assert_count([("processor.event", "transaction"), ("service.name", service_names)], transactions_count)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

terms = [('processor.event', 'transaction'), ('service.name', ['dotnetapp', 'dotnetapp'])]
expected = 1375

    def assert_count(terms, expected):
        """wait a bit for doc count to reach expectation"""
    
        @timeout_decorator.timeout(max_wait)
        def check_count(mut_actual):
            while True:
                rsp = self.es.count(index=self.index, body=self.elasticsearch.term_q(terms))
                mut_actual[0] = rsp["count"]
                if mut_actual[0] >= expected:
                    return
                time.sleep(backoff)
    
        mut_actual = [-1]  # keep actual count in this mutable
        try:
            check_count(mut_actual)
        except timeout_decorator.TimeoutError:
            pass
        actual = mut_actual[0]
>       assert actual == expected, err.format(terms, expected, actual)
E       AssertionError: queried for [('processor.event', 'transaction'), ('service.name', ['dotnetapp', 'dotnetapp'])], expected 1375, got 1374

tests/agent/concurrent_requests.py:131: AssertionError

Steps errors

Expand to view the steps failures

`Windows build`

Took 1 min 57 sec . View more details on here

`Test Sync`

Took 4 min 41 sec . View more details on here
Description: ./.ci/scripts/sync.sh

Log output

Expand to view the last 100 lines of log output

[2021-07-15T02:58:05.974Z] === RUN   TestApplicationMetrics
[2021-07-15T02:58:05.974Z] --- PASS: TestApplicationMetrics (3.84s)
[2021-07-15T02:58:05.974Z] === RUN   TestAPMServerMonitoring
[2021-07-15T02:58:05.974Z] --- PASS: TestAPMServerMonitoring (0.93s)
[2021-07-15T02:58:05.974Z] === RUN   TestAPMServerMonitoringBuiltinUser
[2021-07-15T02:58:05.974Z] --- PASS: TestAPMServerMonitoringBuiltinUser (1.99s)
[2021-07-15T02:58:05.974Z] === RUN   TestAPMServerOnboarding
[2021-07-15T02:58:05.974Z] --- PASS: TestAPMServerOnboarding (3.93s)
[2021-07-15T02:58:05.974Z] === RUN   TestOTLPGRPCTraces
[2021-07-15T02:58:05.974Z] --- PASS: TestOTLPGRPCTraces (4.02s)
[2021-07-15T02:58:05.974Z] === RUN   TestOTLPGRPCMetrics
[2021-07-15T02:58:05.974Z] --- PASS: TestOTLPGRPCMetrics (5.58s)
[2021-07-15T02:58:05.974Z] === RUN   TestOTLPGRPCAuth
[2021-07-15T02:58:05.975Z] --- PASS: TestOTLPGRPCAuth (4.04s)
[2021-07-15T02:58:05.975Z] === RUN   TestOTLPClientIP
[2021-07-15T02:58:05.975Z] --- PASS: TestOTLPClientIP (5.37s)
[2021-07-15T02:58:05.975Z] === RUN   TestRUMXForwardedFor
[2021-07-15T02:58:05.975Z] --- PASS: TestRUMXForwardedFor (4.15s)
[2021-07-15T02:58:05.975Z] === RUN   TestRUMAuth
[2021-07-15T02:58:05.975Z] --- PASS: TestRUMAuth (0.46s)
[2021-07-15T02:58:05.975Z] === RUN   TestRUMAllowServiceNames
[2021-07-15T02:58:05.975Z] --- PASS: TestRUMAllowServiceNames (0.17s)
[2021-07-15T02:58:05.975Z] === RUN   TestRUMRateLimit
[2021-07-15T02:58:05.975Z] --- PASS: TestRUMRateLimit (0.92s)
[2021-07-15T02:58:05.975Z] === RUN   TestKeepUnsampled
[2021-07-15T02:58:05.975Z] === RUN   TestKeepUnsampled/false
[2021-07-15T02:58:05.975Z] === RUN   TestKeepUnsampled/true
[2021-07-15T02:58:05.975Z] --- PASS: TestKeepUnsampled (8.06s)
[2021-07-15T02:58:05.975Z]     --- PASS: TestKeepUnsampled/false (4.26s)
[2021-07-15T02:58:05.975Z]     --- PASS: TestKeepUnsampled/true (3.80s)
[2021-07-15T02:58:05.975Z] === RUN   TestKeepUnsampledWarning
[2021-07-15T02:58:05.975Z] --- PASS: TestKeepUnsampledWarning (4.91s)
[2021-07-15T02:58:05.975Z] === RUN   TestTailSampling
[2021-07-15T02:58:05.975Z]     sampling_test.go:135: waiting for 100 "parent" transactions
[2021-07-15T02:58:05.975Z]     sampling_test.go:135: waiting for 100 "child" transactions
[2021-07-15T02:58:05.975Z] --- PASS: TestTailSampling (6.68s)
[2021-07-15T02:58:05.975Z] === RUN   TestTailSamplingUnlicensed
[2021-07-15T02:58:05.975Z] 2021/07/15 02:56:48 Starting container id: d626db44cae6 image: docker.elastic.co/elasticsearch/elasticsearch:7.14.0-c78a4632-SNAPSHOT
[2021-07-15T02:58:05.975Z] 2021/07/15 02:56:49 Waiting for container id d626db44cae6 image: docker.elastic.co/elasticsearch/elasticsearch:7.14.0-c78a4632-SNAPSHOT
[2021-07-15T02:58:05.975Z] 2021/07/15 02:57:07 Container is ready id: d626db44cae6 image: docker.elastic.co/elasticsearch/elasticsearch:7.14.0-c78a4632-SNAPSHOT
[2021-07-15T02:58:05.975Z] --- PASS: TestTailSamplingUnlicensed (28.58s)
[2021-07-15T02:58:05.975Z] === RUN   TestRUMErrorSourcemapping
[2021-07-15T02:58:05.975Z] --- PASS: TestRUMErrorSourcemapping (5.63s)
[2021-07-15T02:58:05.975Z] === RUN   TestRUMSpanSourcemapping
[2021-07-15T02:58:05.975Z] --- PASS: TestRUMSpanSourcemapping (4.55s)
[2021-07-15T02:58:05.975Z] === RUN   TestDuplicateSourcemapWarning
[2021-07-15T02:58:05.975Z] --- PASS: TestDuplicateSourcemapWarning (5.51s)
[2021-07-15T02:58:05.975Z] === RUN   TestNoMatchingSourcemap
[2021-07-15T02:58:05.975Z] --- PASS: TestNoMatchingSourcemap (4.18s)
[2021-07-15T02:58:05.975Z] === RUN   TestFetchLatestSourcemap
[2021-07-15T02:58:05.975Z] --- PASS: TestFetchLatestSourcemap (6.60s)
[2021-07-15T02:58:05.975Z] === RUN   TestSourcemapCacheUsage
[2021-07-15T02:58:05.975Z] --- PASS: TestSourcemapCacheUsage (4.86s)
[2021-07-15T02:58:05.975Z] === RUN   TestSourcemapCacheExpiration
[2021-07-15T02:58:05.975Z] --- PASS: TestSourcemapCacheExpiration (5.92s)
[2021-07-15T02:58:05.975Z] === RUN   TestIndexTemplateCoverage
[2021-07-15T02:58:05.975Z] --- PASS: TestIndexTemplateCoverage (5.46s)
[2021-07-15T02:58:05.975Z] PASS
[2021-07-15T02:58:05.975Z] ok  	github.com/elastic/apm-server/systemtest	381.741s
[2021-07-15T02:58:05.975Z] === RUN   TestAPMServer
[2021-07-15T02:58:05.975Z] 2021/07/15 02:51:36 Building apm-server...
[2021-07-15T02:58:05.975Z] 2021/07/15 02:51:38 Built /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5716/src/github.com/elastic/apm-server/apm-server
[2021-07-15T02:58:05.975Z] --- PASS: TestAPMServer (2.51s)
[2021-07-15T02:58:05.975Z] === RUN   TestUnstartedAPMServer
[2021-07-15T02:58:05.975Z] --- PASS: TestUnstartedAPMServer (0.00s)
[2021-07-15T02:58:05.975Z] === RUN   TestAPMServerStartTLS
[2021-07-15T02:58:05.975Z] --- PASS: TestAPMServerStartTLS (0.12s)
[2021-07-15T02:58:05.975Z] === RUN   TestExpvar
[2021-07-15T02:58:05.975Z] --- PASS: TestExpvar (0.15s)
[2021-07-15T02:58:05.975Z] PASS
[2021-07-15T02:58:05.975Z] ok  	github.com/elastic/apm-server/systemtest/apmservertest	2.799s
[2021-07-15T02:58:05.975Z] ?   	github.com/elastic/apm-server/systemtest/benchtest	[no test files]
[2021-07-15T02:58:05.975Z] ?   	github.com/elastic/apm-server/systemtest/cmd/apmbench	[no test files]
[2021-07-15T02:58:05.975Z] ?   	github.com/elastic/apm-server/systemtest/estest	[no test files]
[2021-07-15T02:58:05.975Z] ?   	github.com/elastic/apm-server/systemtest/fleettest	[no test files]
[2021-07-15T02:58:05.975Z] + cleanup
[2021-07-15T02:58:05.975Z] + rm -rf /tmp/tmp.uiwRJgtbGp
[2021-07-15T02:58:05.975Z] + .ci/scripts/docker-get-logs.sh
[2021-07-15T02:58:05.975Z] It is not possible to grab the logs of 96df093123f0
[2021-07-15T02:58:07.266Z] Post stage
[2021-07-15T02:58:07.307Z] Running in /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5716/src/github.com/elastic/apm-server/build
[2021-07-15T02:58:07.375Z] Archiving artifacts
[2021-07-15T02:58:07.742Z] Recording test results
[2021-07-15T02:58:08.291Z] [Checks API] No suitable checks publisher found.
[2021-07-15T02:58:08.693Z] + tar --version
[2021-07-15T02:58:09.063Z] + tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests
[2021-07-15T02:58:09.354Z] Archiving artifacts
[2021-07-15T02:58:09.866Z] Terminated
[2021-07-15T02:58:09.845Z] Terminated
[2021-07-15T03:04:57.929Z] [INFO] For detailed information see: https://apm-ci.elastic.co/job/apm-integration-tests-selector-mbp/job/7.x/1172/display/redirect
[2021-07-15T03:05:00.373Z] Copied 26 artifacts from "APM Integration Test MBP Selector » 7.x" build number 1172
[2021-07-15T03:05:02.018Z] Post stage
[2021-07-15T03:05:02.043Z] Recording test results
[2021-07-15T03:05:02.691Z] [Checks API] No suitable checks publisher found.
[2021-07-15T03:05:03.540Z] Running on Jenkins in /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5716
[2021-07-15T03:05:03.675Z] [INFO] getVaultSecret: Getting secrets
[2021-07-15T03:05:03.737Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-07-15T03:05:04.835Z] + chmod 755 generate-build-data.sh
[2021-07-15T03:05:04.835Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-server/apm-server-mbp/PR-5716/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-server/apm-server-mbp/PR-5716/runs/1 UNSTABLE 2658113
[2021-07-15T03:05:04.835Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-server/apm-server-mbp/PR-5716/runs/1/steps/?limit=10000 -o steps-info.json

mergify bot assigned axw Jul 15, 2021

axw merged commit 383b3c9 into 7.14 Jul 15, 2021

axw deleted the mergify/bp/7.14/pr-5704 branch July 15, 2021 04:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[7.14] processor/otel: record array resource attributes (backport #5704) #5716

[7.14] processor/otel: record array resource attributes (backport #5704) #5716

mergify bot commented Jul 15, 2021

apmmachine commented Jul 15, 2021

Build stats

Test stats 🧪

Trends 🧪

`Build and Test / APM Integration Tests / test_concurrent_req_dotnet_foobar – tests.agent.test_dotnet`

`Windows build`

`Test Sync`

[7.14] processor/otel: record array resource attributes (backport #5704) #5716

[7.14] processor/otel: record array resource attributes (backport #5704) #5716

Conversation

mergify bot commented Jul 15, 2021

apmmachine commented Jul 15, 2021

💔 Tests Failed

Build stats

Test stats 🧪

Trends 🧪

Test errors

Build and Test / APM Integration Tests / test_concurrent_req_dotnet_foobar – tests.agent.test_dotnet

Steps errors

Windows build

Test Sync

Log output

`Build and Test / APM Integration Tests / test_concurrent_req_dotnet_foobar – tests.agent.test_dotnet`

`Windows build`

`Test Sync`