-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
processor/otel: record array resource attributes #5704
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an unhandled array attribute is found in resource attributes, store that as a label like we do with span attributes.
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errorsExpand to view the tests failures
|
/test |
1 similar comment
/test |
stuartnelson3
approved these changes
Jul 14, 2021
/test |
mergify bot
pushed a commit
that referenced
this pull request
Jul 15, 2021
* processor/otel: record array resource attributes If an unhandled array attribute is found in resource attributes, store that as a label like we do with span attributes. * processor/otel: handle array attrs for spans (cherry picked from commit 4264a2a)
mergify bot
pushed a commit
that referenced
this pull request
Jul 15, 2021
* processor/otel: record array resource attributes If an unhandled array attribute is found in resource attributes, store that as a label like we do with span attributes. * processor/otel: handle array attrs for spans (cherry picked from commit 4264a2a)
axw
added a commit
that referenced
this pull request
Jul 15, 2021
* processor/otel: record array resource attributes If an unhandled array attribute is found in resource attributes, store that as a label like we do with span attributes. * processor/otel: handle array attrs for spans (cherry picked from commit 4264a2a) Co-authored-by: Andrew Wilkins <[email protected]>
axw
added a commit
that referenced
this pull request
Jul 15, 2021
* processor/otel: record array resource attributes If an unhandled array attribute is found in resource attributes, store that as a label like we do with span attributes. * processor/otel: handle array attrs for spans (cherry picked from commit 4264a2a) Co-authored-by: Andrew Wilkins <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Confirmed against SNAPSHOT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
If an unhandled array attribute is found in resource attributes, store that as a label like we do with span attributes.
Also, handle array attributes when translating to Elastic spans and not just transactions.
Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Documentation has been updatedHow to test these changes
Send a trace with OTLP with array attributes at both the resource and span level, and ensure they are recorded as labels.
Related issues
Fixes #5663