Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add units to metric duration fields #5395

Merged
merged 5 commits into from
Jun 3, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
- name: metricset.period
type: long
description: Current data collection period for this event in milliseconds.
unit: ms
- name: observer.listening
type: keyword
description: |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
- name: metricset.period
type: long
description: Current data collection period for this event in milliseconds.
unit: ms
- name: observer.listening
type: keyword
description: |
Expand Down Expand Up @@ -81,13 +82,15 @@
- name: span.destination.service.response_time.sum.us
type: long
description: Aggregated duration of outgoing requests, in microseconds.
unit: micros
- name: span.self_time.count
type: long
description: Number of aggregated spans.
- name: span.self_time.sum.us
type: long
description: |
Aggregated span duration, excluding the time periods where a direct child was running, in microseconds.
unit: micros
- name: span.subtype
type: keyword
description: |
Expand Down Expand Up @@ -202,6 +205,7 @@
- name: transaction.duration.sum.us
type: long
description: Aggregated transaction duration, in microseconds.
unit: micros
- name: transaction.name
type: keyword
description: |
Expand All @@ -224,6 +228,7 @@
type: long
description: |
Aggregated transaction duration, excluding the time periods where a direct child was running, in microseconds.
unit: micros
- name: transaction.type
type: keyword
description: |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,12 @@
type: long
description: |
Amount of CPU time profiled, in nanoseconds.
unit: nanos
- name: profile.duration
type: long
description: |
Duration of the profile, in microseconds. All samples within a profile will have the same duration. To aggregate durations, you should first group by the profile ID.
Duration of the profile, in nanoseconds. All samples within a profile will have the same duration. To aggregate durations, you should first group by the profile ID.
unit: nanos
- name: profile.id
type: keyword
description: |
Expand Down Expand Up @@ -106,6 +108,7 @@
type: long
description: |
Amount of wall time profiled, in microseconds.
unit: micros
- name: service.environment
type: keyword
description: |
Expand Down
2 changes: 2 additions & 0 deletions changelogs/head.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ https://github.com/elastic/apm-server/compare/7.13\...master[View commits]
* Tail-sampling processor now resumes subscription from previous position after restart {pull}5350[5350]
* Add support for histograms to metrics intake {pull}5360[5360]
* Upgrade Go to 1.16.4 {pull}5381[5381]
* Add units to metric fields {pull}5395[5395]


[float]
==== Deprecated
2 changes: 1 addition & 1 deletion docs/fields.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -2319,7 +2319,7 @@ type: keyword
*`profile.duration`*::
+
--
Duration of the profile, in microseconds. All samples within a profile will have the same duration. To aggregate durations, you should first group by the profile ID.
Duration of the profile, in nanoseconds. All samples within a profile will have the same duration. To aggregate durations, you should first group by the profile ID.


type: long
Expand Down
2 changes: 1 addition & 1 deletion include/fields.go

Large diffs are not rendered by default.

5 changes: 3 additions & 2 deletions model/metricset/_meta/fields.yml
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@
fields:
- name: us
type: long
unit: micros
overwrite: true
description: Aggregated transaction duration, in microseconds.

Expand All @@ -193,6 +194,7 @@
fields:
- name: us
type: long
unit: micros
overwrite: true
description: >
Aggregated transaction duration, excluding the time periods where a
Expand Down Expand Up @@ -245,6 +247,7 @@
fields:
- name: us
type: long
unit: micros
overwrite: true
description: >
Aggregated span duration, excluding the time periods where a
Expand Down Expand Up @@ -421,7 +424,6 @@
overwrite: true
description: >
Hostname of the APM Server.
overwrite: true

- name: version
type: keyword
Expand All @@ -440,7 +442,6 @@
overwrite: true
description: >
The type will be set to `apm-server`.
overwrite: true
axw marked this conversation as resolved.
Show resolved Hide resolved

- name: user
type: group
Expand Down
7 changes: 5 additions & 2 deletions model/profile/_meta/fields.yml
Original file line number Diff line number Diff line change
Expand Up @@ -633,9 +633,10 @@

- name: duration
type: long
unit: nanos
count: 1
description: >
Duration of the profile, in microseconds.
Duration of the profile, in nanoseconds.
All samples within a profile will have the same duration.
To aggregate durations, you should first group by the profile ID.

Expand All @@ -644,15 +645,17 @@
fields:
- name: ns
type: long
unit: nanos
count: 1
description: >
Amount of CPU time profiled, in nanoseconds.

- name: wall
type: group
fields:
- name: us
type: long
unit: micros
count: 1
description: >
Amount of wall time profiled, in microseconds.
Expand Down
2 changes: 2 additions & 0 deletions x-pack/apm-server/fields/_meta/fields.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
short_config: true
fields:
- name: metricset.period
unit: ms
type: long
description: Current data collection period for this event in milliseconds.
- name: span
Expand All @@ -39,5 +40,6 @@
type: long
description: Number of aggregated outgoing requests.
- name: response_time.sum.us
unit: micros
type: long
description: Aggregated duration of outgoing requests, in microseconds.
2 changes: 1 addition & 1 deletion x-pack/apm-server/include/fields.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.