Add units to metric duration fields #5395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
axw
requested changes
Jun 2, 2021
jalvz
commented
Jun 2, 2021
Co-authored-by: Andrew Wilkins <[email protected]>
axw
approved these changes
Jun 3, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jun 3, 2021
* add units to metric duration fields * Apply suggestions from code review Co-authored-by: Andrew Wilkins <[email protected]> * make update * Add changelog Co-authored-by: Andrew Wilkins <[email protected]> (cherry picked from commit fedc1db) # Conflicts: # changelogs/head.asciidoc # include/fields.go
axw
added a commit
that referenced
this pull request
Jun 8, 2021
* Add units to metric duration fields (#5395) * add units to metric duration fields * Apply suggestions from code review Co-authored-by: Andrew Wilkins <[email protected]> * make update * Add changelog Co-authored-by: Andrew Wilkins <[email protected]> (cherry picked from commit fedc1db) # Conflicts: # changelogs/head.asciidoc # include/fields.go * Fix conflicts Co-authored-by: Juan Álvarez <[email protected]> Co-authored-by: Andrew Wilkins <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Jul 6, 2021
* add units to metric duration fields * Apply suggestions from code review Co-authored-by: Andrew Wilkins <[email protected]> * make update * Add changelog Co-authored-by: Andrew Wilkins <[email protected]> (cherry picked from commit fedc1db) # Conflicts: # apmpackage/apm/data_stream/app_metrics/fields/fields.yml # apmpackage/apm/data_stream/internal_metrics/fields/fields.yml # changelogs/head.asciidoc # include/fields.go
|
In light of elastic/elasticsearch#74014 I haven't spent much effort testing this, as we'll need to change things. I checked a few template fields in 7.14 BC1 and they looked good -- this change satisfied the goal of providing real data to Lens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
How to test these changes
Related issues
Closes #4487