Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump apm-data and go-docappender to stable version #12604

Merged
merged 6 commits into from
Feb 7, 2024

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Feb 7, 2024

Motivation/summary

Future updates should be picked up by dependabot

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Closes #12268

@kruskall kruskall requested a review from a team as a code owner February 7, 2024 16:14
Copy link
Contributor

mergify bot commented Feb 7, 2024

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Feb 7, 2024
Copy link
Contributor

mergify bot commented Feb 7, 2024

This pull request is now in conflicts. Could you fix it @kruskall? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feat/bump-lib upstream/feat/bump-lib
git merge upstream/main
git push upstream feat/bump-lib

@kruskall kruskall enabled auto-merge (squash) February 7, 2024 17:20
Comment on lines +699 to +703
minFlush := 24 * 1024
if esConfig.CompressionLevel != 0 && flushBytes < minFlush {
s.logger.Warnf("flush_bytes config value is too small (%d) and might be ignored by the indexer, increasing value to %d", flushBytes, minFlush)
flushBytes = minFlush
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change part of the bump?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Test fails now that we have merged elastic/go-docappender#111

Copy link
Member

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a changelog entry for the docappender changes? Is this a good time to add one?

@kruskall kruskall merged commit 0062c13 into elastic:main Feb 7, 2024
9 checks passed
@marclop marclop self-assigned this Mar 20, 2024
@marclop
Copy link
Contributor

marclop commented Mar 20, 2024

Change log updated in #12823.

@kruskall kruskall deleted the feat/bump-lib branch April 17, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify test-plan test-plan-ok v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add automation for updating main to the latest apm-data and go-docappender commits
4 participants