-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump apm-data and go-docappender to stable version #12604
Conversation
This pull request does not have a backport label. Could you fix it @kruskall? 🙏
NOTE: |
This pull request is now in conflicts. Could you fix it @kruskall? 🙏
|
minFlush := 24 * 1024 | ||
if esConfig.CompressionLevel != 0 && flushBytes < minFlush { | ||
s.logger.Warnf("flush_bytes config value is too small (%d) and might be ignored by the indexer, increasing value to %d", flushBytes, minFlush) | ||
flushBytes = minFlush | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change part of the bump?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
Test fails now that we have merged elastic/go-docappender#111
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have a changelog entry for the docappender changes? Is this a good time to add one?
Change log updated in #12823. |
Motivation/summary
Future updates should be picked up by dependabot
Checklist
For functional changes, consider:
How to test these changes
Related issues
Closes #12268