Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automation for updating main to the latest apm-data and go-docappender commits #12268

Closed
simitt opened this issue Dec 20, 2023 · 3 comments · Fixed by #12519 or #12604
Closed

Add automation for updating main to the latest apm-data and go-docappender commits #12268

simitt opened this issue Dec 20, 2023 · 3 comments · Fixed by #12519 or #12604
Assignees

Comments

@simitt
Copy link
Contributor

simitt commented Dec 20, 2023

Some core functionality for the apm-server moved to https://github.com/elastic/apm-data and to https://github.com/elastic/go-docappender some time ago. It is important to keep the apm-server updated with the latest features in bug fixes in these libraries. We should add automation for regularly updating the dependency in the main branch of the apm-server.

@inge4pres
Copy link
Contributor

inge4pres commented Dec 20, 2023

If we pull apm-data into apm-server via go mod, the simplest solution that comes to mind is to add a

go get github.com/elastic/apm-data@latest

as part of a git hook or a CI job on Pull Requests.
The hook or job should possibly commit the change to go.mod and go.sum if there was an update.

@simitt simitt changed the title Add automation for updating main to the latest apm-data commits Add automation for updating main to the latest apm-data and go-docappender commits Jan 4, 2024
@kruskall kruskall reopened this Feb 6, 2024
@kruskall
Copy link
Member

kruskall commented Feb 6, 2024

Turned out dependabot does not support pseudo versions: dependabot/dependabot-core#2028

(thanks @axw for the link!)

Possible solutions are:

  • semver releases for those libraries
  • use updatecli similar to what we are doing for beats

@kruskall
Copy link
Member

kruskall commented Feb 7, 2024

We've released stable versions, this should be fixed once the PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants