Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove async arg #199

Merged
merged 1 commit into from
Jan 11, 2024
Merged

remove async arg #199

merged 1 commit into from
Jan 11, 2024

Conversation

SylvainJuge
Copy link
Member

Follow-up of #193 , the async parameter was removed, but the HandleStream interface was not updated to reflect this.

This currently prevents updating apm-data version used in apm-server.

Once this is merged elastic/apm-server#12386 will be unblocked and must have its version of apm-data updated.

@SylvainJuge SylvainJuge requested a review from a team as a code owner January 11, 2024 10:34
@SylvainJuge SylvainJuge requested a review from kruskall January 11, 2024 10:35
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for this oversight, and thanks for contributing the fix.

@SylvainJuge
Copy link
Member Author

Thanks @simitt for the review, can we merge this now ?

As a follow-up we should probably set-up a CI job that ensures apm-server main branch is tested with the current state of apm-data main branch, or 100x better an automatic PR is created to update apm-data in apm-server so we have feedback when changes merged in apm-data break something. Given we expect contributions from outside of the apm-server team this is quite likely to happen (my future self is the one that is likely to make this kind of oversight).

@simitt
Copy link
Contributor

simitt commented Jan 11, 2024

or 100x better an automatic PR is created to update apm-data in apm-server so we have feedback when changes merged in apm-data break something

agreed; created elastic/apm-server#12268 recently

@simitt simitt merged commit 80b6af8 into elastic:main Jan 11, 2024
4 checks passed
@SylvainJuge SylvainJuge deleted the remove-async-again branch January 11, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants