Implement #73 integration tests for .NET #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds .NET auto attachment tests
github-actions
bot
added
the
apm-k8s-attacher
|
run docs-build |
|
Finally got around to getting this to work 🎉 @jackshirazi @trentm tagging you to review since you done the |
trentm
approved these changes
Jul 9, 2024
| ELASTIC_APM_PROFILER_INTEGRATIONS: "/usr/agent/apm-dotnet-agent/integrations.yml" | ||
| CORECLR_PROFILER_PATH: "/elastic/apm/agent/apm-dotnet-agent/libelastic_apm_profiler.so" | ||
| ELASTIC_APM_PROFILER_HOME: "/elastic/apm/agent/apm-dotnet-agent" | ||
| ELASTIC_APM_PROFILER_INTEGRATIONS: "/elastic/apm/agent/apm-dotnet-agent/integrations.yml" |
There was a problem hiding this comment.
Was the attacher just not working for .NET before this change, then? I.e. will we need/want a new release of the attacher with this change?
There was a problem hiding this comment.
Yeah, I will double check but I am 90÷ sure this never worked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds .NET auto attachment tests