Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minimal test for .NET #73

Closed
gregkalapos opened this issue Mar 30, 2023 · 1 comment
Closed

Add minimal test for .NET #73

gregkalapos opened this issue Mar 30, 2023 · 1 comment
Assignees
@Mpdreamz
Labels
apm-k8s-attacher Mutating Webhook to attach apm agents on k8s

Comments

@gregkalapos
Copy link
Contributor

Currently the test coverage for .NET is very little: https://github.com/elastic/apm-mutating-webhook/tree/main/test

We should add a minimal test, following the Node.js test.

What should be covered (feel free to extend or change if it makes sense):

  • Real container is started with a minimal sample app
  • A real request runs against the sample app
  • The test makes sure the agent was injected properly and captured the call
  • Tests fails if the agent did not capture the call

Same for Java: #72
@gregkalapos gregkalapos mentioned this issue Mar 30, 2023
Closed
@github-actions github-actions bot added the apm-k8s-attacher Mutating Webhook to attach apm agents on k8s label Mar 30, 2023
Mpdreamz added a commit that referenced this issue Jul 10, 2024
@Mpdreamz
Implement #73 integration tests for .NET (#83)
445b4ef 
* Implement #73 integration tests for .NET

This adds .NET auto attachment tests

* make sure we get the logs for dotnet-test-app not java-test-app

* ensure app logs at trace level

* enable stdout logging

* ensure we use /elastic/apm/ as mount path

* update agent_has_started grep for agent presence

* :grep => grep, trying out fleet but its VI bindings are still crap :)

* more info from agent_has_started.sh

* simpler grep
@Mpdreamz
Copy link
Member

Implemented as part of #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mpdreamz Mpdreamz

Labels
apm-k8s-attacher Mutating Webhook to attach apm agents on k8s
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mpdreamz @gregkalapos