Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow datapoint attributes to override user.name #317

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

lahsivjar
Copy link
Contributor

With elastic/opentelemetry-lib#42, otel-lib sets a default non-empty value to user.name. This has been done to allow the UI to not crash if the field is missing for certain setups. Due to this change, APM-data needs to allow the user.name to be overridden as data-point attributes.

@lahsivjar lahsivjar requested a review from a team as a code owner July 9, 2024 10:25
@obltmachine obltmachine added the safe-to-test Changes are safe to run in the CI label Jul 9, 2024
@lahsivjar lahsivjar enabled auto-merge (squash) July 9, 2024 10:26
@lahsivjar lahsivjar merged commit 1542936 into elastic:main Jul 9, 2024
6 checks passed
@lahsivjar lahsivjar deleted the fix-user_name branch July 9, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe-to-test Changes are safe to run in the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants