Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore ESM testing with Node.js >=v18.19.0 and v20 and v21; clarify ESM Node.js version support #3857

Merged
merged 3 commits into from
Feb 2, 2024
Merged

fix: restore ESM testing with Node.js >=v18.19.0 and v20 and v21; clarify ESM Node.js version support #3857

merged 3 commits into from
Feb 2, 2024

Conversation

trentm
Copy link
Member

@trentm trentm commented Feb 1, 2024 •
edited
Loading

The [email protected] update has resolved ESM instrumentation issues
with Node.js ^18.19.0 || >=20.2.0.

Closes: #3784
Obsoletes: #3785
Refs: #3844

Note that the @@toStringTag issue impacting OTel doesn't impact us.

@trentm
fix: attempt ESM testing with Node.js >=v18.19.0 and v20 and v21 again
1551ce8 
This is to see if [email protected] has resolved ESM instrumentation issues for
this agent.
@trentm trentm self-assigned this Feb 1, 2024
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Feb 1, 2024
trentm
trentm commented Feb 2, 2024
View reviewed changes
Copy link
Member Author

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test tav

@trentm trentm marked this pull request as ready for review February 2, 2024 01:13
@trentm trentm requested a review from david-luna February 2, 2024 01:13
@trentm
Copy link
Member Author

trentm commented Feb 2, 2024 •
edited
Loading

@trentm trentm changed the title fix: attempt ESM testing with Node.js >=v18.19.0 and v20 and v21 again fix: restore ESM testing with Node.js >=v18.19.0 and v20 and v21; clarify ESM Node.js version support Feb 2, 2024
@trentm trentm merged commit 55f9b7b into main Feb 2, 2024
193 checks passed
@trentm trentm deleted the trentm/esm-support-with-iitm173 branch February 2, 2024 19:24
This was referenced Feb 2, 2024
Closed
Merged
fpm-peter pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
@trentm @fpm-peter
fix: restore ESM testing with Node.js >=v18.19.0 and v20 and v21; cla…
afe008a 
…rify ESM Node.js version support (elastic#3857)

With the recent update to [email protected] our ESM support
is working with Node.js v18.19.0, and with v20 and v21 (`^18.1.0 || >=20.2.0`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-luna david-luna david-luna approved these changes

Assignees

@trentm trentm

Labels
agent-nodejs Make available for APM Agents project planning.
Projects
APM-Agents (OLD)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESM instrumentation/hooking fails with Node.js v18.19.0
2 participants
@trentm @david-luna