-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ESM hooking with Node.js v18.19.0 #3785
Conversation
[email protected] fixes an issue with double-importing with node 18.19.0 (due to a backport of ESM loading being done off main thread). Fixes: #3784
Sigh. Now we are hitting the other issue in IITM when used with Node.js versions that use off-main-thread ESM loading: E.g. from https://github.com/elastic/apm-agent-nodejs/actions/runs/7171406915/job/19526333837?pr=3785
|
Ultimately we'll want a fix for that issue -- there is an in-progres PR for that: nodejs/import-in-the-middle#30 Either we sit on this PR, or we could workaround this second issue and avoid testing the affected subset of modules with node v18.19.0. |
As discussed let's make workaround until nodejs/import-in-the-middle#30 is merged and published. |
There was a recent IITM commit (nodejs/import-in-the-middle#43) with what I think is a fix for this. It is a very different impl of the issue. I haven't yet had a chance to test whether that fixes the same issue. Also, it isn't yet in an IITM release. |
Superseded by #3857 |
[email protected] fixes an issue with double-importing
with node 18.19.0 (due to a backport of ESM loading being done
off main thread).
Fixes: #3784