chore: support 'K8S_ATTACH' value for 'ELASTIC_APM_ACTIVATION_METHOD' #3821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#3819) (Backport of commit 7c0ba9d from main branch.) This is a the new favoured value for the envvar to indicate the apm-k8s-attacher is being used. This should be backported. Refs: elastic/apm-k8s-attacher#91
github-actions
bot
added
the
agent-nodejs
|
Some of the test failures went away with a re-run. The "test / test-vers (18)" is failing consistently because of #3823 I'm inclined to backport #3783 to the 3.x branch as well to avoid this. |
|
@david-luna This is ready for review now. Then I'll prepare a release-3.50.1 PR afterwards. |
david-luna
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Backport of commit 7c0ba9d from main branch.)
This is a the new favoured value for the envvar to indicate the apm-k8s-attacher is being used.
This should be backported.
Refs: elastic/apm-k8s-attacher#91