Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support 'K8S_ATTACH' value for 'ELASTIC_APM_ACTIVATION_METHOD' #3819

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

trentm
Copy link
Member

@trentm trentm commented Jan 11, 2024

This is a the new favoured value for the envvar to indicate the apm-k8s-attacher
is being used. This still supports the old 'K8S' value, so the current release of
apm-k8s-attacher still works to properly set activation_method.

This should be backported.

Refs: elastic/apm-k8s-attacher#91

This is a the new favoured value for the envvar to indicate the apm-k8s-attacher
is being used.
This should be backported.

Refs: elastic/apm-k8s-attacher#91
@trentm trentm requested a review from david-luna January 11, 2024 07:11
@trentm trentm self-assigned this Jan 11, 2024
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Jan 11, 2024
@trentm trentm merged commit 7c0ba9d into main Jan 11, 2024
18 checks passed
@trentm trentm deleted the trentm/activation-method-new-envvar-val branch January 11, 2024 17:42
trentm added a commit that referenced this pull request Jan 11, 2024
…#3819)

(Backport of commit 7c0ba9d from main branch.)
This is a the new favoured value for the envvar to indicate the apm-k8s-attacher
is being used.
This should be backported.

Refs: elastic/apm-k8s-attacher#91
trentm added a commit that referenced this pull request Jan 12, 2024
…#3819) (#3821)

(Backport of commit 7c0ba9d from main branch.)
This is a the new favoured value for the envvar to indicate the apm-k8s-attacher
is being used.
This should be backported.

Refs: elastic/apm-k8s-attacher#91
fpm-peter pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
…elastic#3819)

This is a the new favoured value for the envvar to indicate the apm-k8s-attacher
is being used.
This should be backported.

Refs: elastic/apm-k8s-attacher#91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants