instance-selector is now patched to work w/ EKS AMI V20220123

[bwagner5]

Description

ec2-instance-selector was unnecessarily validating that the version of the EKS AMI (https://github.com/awslabs/amazon-eks-ami/releases/tag/v20220123) was prepended with a lowercase v. But the latest release of the AMI had an uppercase V (has since been fixed). A patch was put into place in eksctl (#4681). The EC2 Instance Selector has since been patched (aws/amazon-ec2-instance-selector#112) and so the eksctl patch can be reverted and point to the latest commit of the official instance-selector repo.

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the userdocs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes
• (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[bwagner5]

Manual Testing:

$ make binary
$ ./eksctl create nodegroup --instance-selector-vcpus 2 --dry-run --cluster my-demo
apiVersion: eksctl.io/v1alpha5
kind: ClusterConfig
managedNodeGroups:
- amiFamily: AmazonLinux2
  desiredCapacity: 2
  disableIMDSv1: false
  disablePodIMDS: false
  iam:
    withAddonPolicies:
      albIngress: false
      appMesh: false
      appMeshPreview: false
      autoScaler: false
      certManager: false
      cloudWatch: false
      ebs: false
      efs: false
      externalDNS: false
      fsx: false
      imageBuilder: false
      xRay: false
  instanceSelector:
    vCPUs: 2
  instanceTypes:
  - c4.large
  - c5.large
  - c5a.large
  - c5d.large
  - c5n.large
  - c6i.large
  - i3.large
  - i3en.large
 .....

[cPu1]

LGTM. Thanks!

[patstrom]

Cheers 🎉

Will this be released as a patch or will it be included in the next minor release (in ~2 weeks?)?

[cPu1]

Cheers tada

Will this be released as a patch or will it be included in the next minor release (in ~2 weeks?)?

You don't need to wait for a patch release. The EKS AMI repo has fixed its release tag, so your existing version of eksctl will now work.

[patstrom]

You don't need to wait for a patch release. The EKS AMI repo has fixed its release tag, so your existing version of eksctl will now work.

Oh wow. Even better 🎉