Fix fetching EKS AMI release archive #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changelist fixes fetching the EKS AMI release archive by removing the check for adding a `v` prefix if it does not exist. The last release published a [tag](https://github.com/awslabs/amazon-eks-ami/releases/tag/V20220123) that begins with an uppercase `V` and the code ends up prepending an additional `v`, rendering the URL incorrect. Rather than accounting for this case in code, this changelist removes that check altogether as `amazon-eks-ami` has been consistently adding the `v` prefix to their tags.
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changelist fixes fetching the EKS AMI release archive by removing the check for adding a
vprefix if it does not exist.The last release published a tag that begins with an uppercase
Vand the code ends up prepending an additionalv, rendering the URL incorrect. Rather than accounting for this case in code, this changelist removes that check altogether asamazon-eks-amihas been consistently adding thevprefix to their tags.Fixes #111
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.