Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow nodes to write CloudWatch metrics #296

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Allow nodes to write CloudWatch metrics #296

merged 1 commit into from
Nov 1, 2018

Conversation

errordeveloper
Copy link
Contributor

Description

This is primarily in order to facilitate exporting CNI metrics (ref #278)

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All tests passing (i.e. make test)

@errordeveloper
Allow nodes to write CloudWatch metrics
6d13a19 
This is primarily in order to facilitate exporting CNI metrics (ref #278)
@errordeveloper errordeveloper mentioned this pull request Nov 1, 2018
Closed
stefanprodan
stefanprodan approved these changes Nov 1, 2018
View reviewed changes
Copy link
Contributor

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@errordeveloper errordeveloper merged commit 80af1ed into master Nov 1, 2018
@errordeveloper errordeveloper deleted the fix-278 branch November 1, 2018 08:56
@errordeveloper errordeveloper mentioned this pull request May 1, 2019
Closed
@wreulicke wreulicke mentioned this pull request Jun 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@errordeveloper @stefanprodan