Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudWatch Metrics for AWS CNI plugin #278

Closed
PaulMaddox opened this issue Oct 21, 2018 · 7 comments
Closed

CloudWatch Metrics for AWS CNI plugin #278

PaulMaddox opened this issue Oct 21, 2018 · 7 comments
Assignees
Labels
area/add-ons kind/feature New feature or request

Comments

@PaulMaddox
Copy link
Contributor

The AWS CNI plugin allows automatically exporting the following metrics to CloudWatch:

  • The number of errors encountered in ipamd
  • The number of ipamd actions inprogress
  • The maximum number of ENIs that can be attached to the instance
  • The maximum number of IP addresses that can be allocated to the instance
  • The number of times ipamD reconciles on ENIs and IP addresses
  • The number of add IP address request
  • The number of delete IP address request
  • The number of ENIs allocated
  • The total number of IP addresses
  • The number of IP addresses assigned to pods
  • AWS API call latency in ms
  • The number of times AWS API returns an error
  • The number of errors not handled in awsutils library

example

These are super useful for EKS cluster administrators, and correct use of dashboards/alarms can save pain.

In order for this to work, the following needs to be added to eksctl:

@PaulMaddox PaulMaddox changed the title IAM to allow CloudWatch Metrics for AWS CNI plugin CloudWatch Metrics for AWS CNI plugin Oct 21, 2018
@PaulMaddox
Copy link
Contributor Author

Example CloudWatch Dashboard

example-cni-dashboard

@Lazyshot Lazyshot added the kind/feature New feature or request label Oct 22, 2018
@Lazyshot Lazyshot added this to the 0.2.0 – add-ons milestone Oct 22, 2018
@errordeveloper
Copy link
Contributor

errordeveloper commented Oct 22, 2018

I guess we could just enable the permission without a flag. I believe the only implications would be that someone can flood CloudWatch with metrics, which impacts the bill. Creation of dashboard would have to wait for add-ons capability.

@errordeveloper
Copy link
Contributor

@PaulMaddox do you agree with my assessment above?

@errordeveloper
Copy link
Contributor

I'll open a PR to add IAM role, and we can get it into this week's release.

@PaulMaddox
Copy link
Contributor Author

👍

errordeveloper added a commit that referenced this issue Nov 1, 2018
This is primarily in order to facilitate exporting CNI metrics (ref #278)
@errordeveloper
Copy link
Contributor

#296 will add the role, the rest of this feature will have to wait until add-ons are a thing (see #242).

@michaelbeaumont
Copy link
Contributor

This is unlikely to be prioritized.
We are tending away from adding more special case addons to eksctl. Using this plugin may be possible at some point using cluster addons or gitops but it won't be a special case as part of eksctl directly.
Please let us know here or in a new issue if there's something eksctl does that makes using this plugin especially difficult or if you think it really is justified being part of eksctl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/add-ons kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants