Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marked 1.12 as End of Support #2030

Merged
merged 1 commit into from
May 5, 2020
Merged

Marked 1.12 as End of Support #2030

merged 1 commit into from
May 5, 2020

Conversation

sayboras
Copy link
Contributor

@sayboras sayboras commented Apr 13, 2020 •
edited by marccarre
Loading

Description

Fixes #1951

Approach

I scanned the code, and saw a lot of places we are using 1.12 in unit test. So I take this chance to update those test cases as well.

Create new cluster with 1.12 
$ ./eksctl create cluster --version 1.12                     
[ℹ]  eksctl version 0.18.0-dev+3cd4c28f.2020-04-13T23:30:58Z
[ℹ]  using region ap-southeast-2
Error: invalid version, 1.12 is no longer supported, supported values: 1.13, 1.14, 1.15

Fun fact 😆

I didn't plan to work on this one, but just remember that my very first PR in eksctl was to deprecate 1.11 #1384. So with this PR, I can call myself as DEPRECATOR 😆 🎉 🥇

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the site/content directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@sayboras sayboras changed the title Marked 1.11 as deprecated Marked 1.12 as EOL Apr 13, 2020
@sayboras sayboras changed the title Marked 1.12 as EOL Marked 1.12 as End of Support Apr 13, 2020
@sayboras sayboras changed the title Marked 1.12 as End of Support Marked 1.12 as End of Support (DO NOT MERGE before 11 May) Apr 13, 2020
@sayboras sayboras force-pushed the feature/deprecate-1-12 branch from b649f19 to 9fa8251 Compare April 15, 2020 09:42
@sayboras
Copy link
Contributor Author

Build failed due to un-related changes. Fix is available in #2036

@sayboras sayboras force-pushed the feature/deprecate-1-12 branch 2 times, most recently from 6f59132 to b8cf05c Compare April 16, 2020 10:09
@martina-if martina-if changed the title Marked 1.12 as End of Support (DO NOT MERGE before 11 May) WIP Marked 1.12 as End of Support (DO NOT MERGE before 11 May) Apr 16, 2020
martina-if
martina-if reviewed Apr 16, 2020
View reviewed changes
Copy link
Contributor

@martina-if martina-if left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I will officially approve it when it's time to merge 👍 thanks Mr. DEPRECATOR!

sayboras
sayboras commented Apr 16, 2020
View reviewed changes
pkg/eks/api_test.go
@@ -94,19 +94,19 @@ var _ = Describe("eksctl API", func() {
ng.AMI = "static"
ng.InstanceType = "p2.xlarge"

err := EnsureAMI(provider, "1.12", ng)
err := EnsureAMI(provider, "1.14", ng)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used 1.14 as it's the lastest version that we have static AMI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(the above comment is from Goland) :)

@sayboras sayboras closed this Apr 16, 2020
@sayboras sayboras reopened this Apr 16, 2020
@sayboras sayboras force-pushed the feature/deprecate-1-12 branch 3 times, most recently from 6719b93 to e6a17b6 Compare April 23, 2020 12:28
@sayboras sayboras force-pushed the feature/deprecate-1-12 branch 6 times, most recently from 1abac85 to e90d1d9 Compare May 4, 2020 12:32
@sayboras sayboras force-pushed the feature/deprecate-1-12 branch from e90d1d9 to b6dcfe3 Compare May 5, 2020 13:54
@sayboras sayboras changed the title WIP Marked 1.12 as End of Support (DO NOT MERGE before 11 May) Marked 1.12 as End of Support May 5, 2020
@martina-if martina-if merged commit e481b30 into eksctl-io:master May 5, 2020
@sayboras sayboras deleted the feature/deprecate-1-12 branch May 5, 2020 14:25
@sayboras sayboras mentioned this pull request May 6, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martina-if martina-if martina-if approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubernetes v1.12 End of Support (May 11, 2020)
2 participants
@sayboras @martina-if