Marked 1.11 as deprecated #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayboras
force-pushed
the
feature/depreciate-1-11
branch
from
d9a4e9a to
438cba9
Compare
|
Hi @sayboras thank you for your PR.I will mark this as "needs changes" so we don't accidentally merge it too early. |
martina-if
suggested changes
Oct 4, 2019
cPu1
reviewed
Oct 7, 2019
pkg/apis/eksctl.io/v1alpha5/types.go
Outdated
| @@ -226,14 +226,13 @@ func SupportedRegions() []string { | |||
| // https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html | |||
| func DeprecatedVersions() []string { | |||
| return []string{ | |||
| Version1_10, | |||
| Version1_10, Version1_11, | |||
There was a problem hiding this comment.
Minor nit:
Suggested change
| Version1_10, Version1_11, | |
| Version1_10, | |
| Version1_11, |
Or
return []string{Version1_10, Version1_11}
|
@martina-if as 0.8.0 is already released, the next release will be after 04 Nov, just want to check if we can merge this PR now. |
|
@sayboras great! thank you for the reminder. Can you rebase so I can approve it and merge it? |
|
@martina-if it's ready to merge now 💯 |
martina-if
approved these changes
Nov 4, 2019
5 tasks
This was referenced May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes for #1375. Only merge after 4 Nov 2019.
Checklist
make build)make test)README.md, andexamplesdirectory)