[goals] [fleche] Add tactic-based preprocessing to goals request. #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejgallego
added
kind: enhancement
ejgallego
added a commit
that referenced
this pull request
Oct 13, 2023
This way other extensions can implement their own commands that query Coq goals With #574, close #558 Co-authored-by: Ambroise Lafont <[email protected]>
ejgallego
added a commit
that referenced
this pull request
Oct 13, 2023
This way other extensions can implement their own commands that query Coq goals With #574, close #558 Co-authored-by: Ambroise Lafont <[email protected]>
ejgallego
force-pushed
the
add_pretac_to_query
branch
2 times, most recently
from
054e67a to
8600c70
Compare
ejgallego
added a commit
that referenced
this pull request
Oct 13, 2023
This way other extensions can implement their own commands that query Coq goals With #574, close #558 Co-authored-by: Ambroise Lafont <[email protected]>
ejgallego
added a commit
that referenced
this pull request
Oct 13, 2023
This way other extensions can implement their own commands that query Coq goals With #574, close #558 Co-authored-by: Ambroise Lafont <[email protected]>
ejgallego
force-pushed
the
add_pretac_to_query
branch
from
8600c70 to
fac4d8a
Compare
ejgallego
added a commit
that referenced
this pull request
Oct 16, 2023
This way other extensions can implement their own commands that query Coq goals With #574, close #558 Co-authored-by: Ambroise Lafont <[email protected]>
ejgallego
added a commit
that referenced
this pull request
Oct 16, 2023
This way other extensions can implement their own commands that query Coq goals With #574, close #558 Co-authored-by: Ambroise Lafont <[email protected]>
ejgallego
added a commit
that referenced
this pull request
Oct 22, 2023
This way other extensions can implement their own commands that query Coq goals With #574, close #558 Co-authored-by: Ambroise Lafont <[email protected]>
We add a new parameter `pretac` to the `GoalRequest`, that allows to query for goals but running a set of tactics (or commands) first. This is an experiment for now; in particular it'd be nice to rework the API for speculative execution prior merge. Co-authored-by: Ambroise Lafont <[email protected]>
ejgallego
force-pushed
the
add_pretac_to_query
branch
from
fac4d8a to
493805d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a new parameter
pretacto theGoalRequest, that allows to query for goals but running a set of tactics (or commands) first.This is an experiment for now; in particular it'd be nice to rework the API for speculative execution prior merge.
This should help a great way towards #558