This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
Don't upload replays twice #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- writes new replays to the db - refreshes after an update
|
This will do for 2.0.1. For next release we may want to invent an async unique entry queue system that the initial pass and the uploaderservice push to. |
|
I'm currently trying a more efficient version for the create all on startup, so maybe we get the best out of 2.0.1 though. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for issue #91.
I could isolate, why that happens:
Uploaded files didn't get persisted correctly on a first run. A second run was needed. So that meant, that every file had to be uploaded / parsed twice.
This was fixed by: