Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Files get uploaded twice #91

Closed
simarsenault opened this issue Dec 7, 2015 · 2 comments
Closed

Files get uploaded twice #91

simarsenault opened this issue Dec 7, 2015 · 2 comments
Labels
Milestone

Comments

@simarsenault
Copy link

The following happens on my machine (Windows 10):

I open HotS Replay Uploader then I play a few games (let say 3). Each replay is uploaded as soon as the game finishes. Then I close the JAR, reopen it and the 3 replays are uploaded again. However, if I close the JAR again and reopen it, the 3 replays won't be uploaded again.

If I have some time this week I'll fire up IntelliJ and try to find why this happens.

@zhedar
Copy link
Collaborator

zhedar commented Dec 7, 2015

Thanks for reporting, this is already a known issue we sinked several hours into.
Our assumption is, that the h2 database is to blame. Somehow the data isn't written to the store, if not enough bytes are in the buffer. However this may be completely wrong, as the data is saved correctly after the second run. Changing the DBMS for 2.1 is a possible solution, but fixing this may be even better.
If you know something about that or just feel like trying around a bit, feel free to track this one down, any hints would be highly appreciated.

A note on that: Since we introduced a parser functionality in 2.0, the replays aren't really uploaded again. They are parsed, a single http request (for each replay file) is made and the file get's recognized as already uloaded.

Edit: Just found a not so elegant workaround. The first startup will take significantly longer with this one applied, but that may be something we could work with. However it's getting late, so I will update this tomorrow.

@zhedar zhedar added the bug label Dec 7, 2015
zhedar added a commit that referenced this issue Dec 7, 2015
- writes new replays to the db
- refreshes after an update
@zhedar zhedar added this to the 2.0.1 milestone Dec 7, 2015
@eivindveg
Copy link
Owner

Fixed by #93

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants