Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous Integration #22

Merged
merged 1 commit into from
May 7, 2018
Merged

Continuous Integration #22

merged 1 commit into from
May 7, 2018

Conversation

Nemo157
Copy link
Contributor

@Nemo157 Nemo157 commented May 7, 2018

I assume someone with permission would have to enable this repository in Travis CI, not sure what exact permission that would be though.

@wking
Copy link
Contributor

wking commented May 7, 2018

I assume someone with permission would have to enable this repository in Travis CI, not sure what exact permission that would be though.

Looks like it's an org admin (docs). Travis has some docs here, but I'm not sure if that's for the new GitHub App approach. Perhaps an org admin needs to go through the process starting here for the $0 open source plan? @carols10cents, could you look into setting this up at the org level?

@wking
Copy link
Contributor

wking commented May 7, 2018

Moving the fetcher to a separate, unpublished crate makes sense to me, and seems orthogonal to CI. Can you spin it out into a separate PR?

@Nemo157
Copy link
Contributor Author

Nemo157 commented May 7, 2018

Sure


matrix:
include:
- os: osx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to include - os: linux as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is linux, this adds an extra build that is run against macOS on top of those. You can see the full build matrix here: https://travis-ci.org/Nemo157/license-exprs/builds/376051360

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How it actually works, each entry in the include array defines one job, the first job here overrides the os to be osx and uses the default rust version, the other 3 jobs each override the rust version and use the default os of linux.

Copy link
Contributor

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Unless someone weighs in with additional issues, I'll merge it once @carols10cents has time to enable Travis for the org.

@carols10cents
Copy link
Contributor

@wking wking merged commit 1f37d24 into ehuss:master May 7, 2018
@wking
Copy link
Contributor

wking commented May 7, 2018

I think I did it? https://travis-ci.com/rust-lang-nursery/license-exprs

Yup, looks good to me. I've merged this branch, and the new master is running through its tests here. Maybe I should have kicked Travis somehow before merging to make sure everything passed, but it's too late now ;).

@Nemo157
Copy link
Contributor Author

Nemo157 commented May 8, 2018

I guess it's under travis-ci.com instead of travis-ci.org because it's using the new check application support? I wonder if all the other rust-lang-nursery projects should migrate: https://travis-ci.org/rust-lang-nursery

@Nemo157 Nemo157 deleted the ci branch May 8, 2018 11:50
@wking
Copy link
Contributor

wking commented May 8, 2018

I guess it's under travis-ci.com instead of travis-ci.org because it's using the new check application support?

Yeah, see here and here.

I wonder if all the other rust-lang-nursery projects should migrate: https://travis-ci.org/rust-lang-nursery

They have a migration tool, if folks want to do that in bulk. And without that, you can also opt-in to having Travis migrate you.

wking added a commit to wking/license-exprs that referenced this pull request Jun 18, 2018
Changes since v1.3.0:

* Updated SPDX License List to 3.1 (ehuss#9, ehuss#11, ehuss#17, ehuss#19, ehuss#24)
* Updated SPDX License Expression reference from 2.0 to 2.1 (ehuss#8).
* Document our license-list version, parens issue, and license (ehuss#16,
  ehuss#17).
* Add Travis CI configuration (ehuss#22).
* Add additional test cases (ehuss#25).
* .mailmap: Consolidate authors (ehuss#26).
@wking wking mentioned this pull request Jun 18, 2018
wking added a commit to wking/license-exprs that referenced this pull request Jun 18, 2018
Changes since v1.3.0:

* Updated SPDX License List to 3.1 (ehuss#9, ehuss#11, ehuss#17, ehuss#19, ehuss#24).
* Updated SPDX License Expression reference from 2.0 to 2.1 (ehuss#8).
* Document our license-list version, parens issue, and license (ehuss#16,
  ehuss#17).
* Add Travis CI configuration (ehuss#22).
* Add additional test cases (ehuss#25).
* .mailmap: Consolidate authors (ehuss#26).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants