Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move fetch-license-list-from-spdx to separate crate #24

Merged
merged 1 commit into from
May 13, 2018

Conversation

Nemo157
Copy link
Contributor

@Nemo157 Nemo157 commented May 7, 2018

Avoids building a large dependency tree when running tests.
Marked as unpublishable to avoid accidental publishing.

Copy link
Contributor

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I'll give it until Friday in case anyone else wants to comment (@nodakai?) and then merge.

@nodakai
Copy link
Contributor

nodakai commented May 8, 2018

Kool, good to learn about a clever use of Cargo workspace.

Working flawlessly on my local checkout.

Avoids building a large dependency tree when running tests.
Marked as unpublishable to avoid accidental publishing.
@Nemo157 Nemo157 force-pushed the separate-fetcher branch from b3197d1 to 635eaf1 Compare May 8, 2018 16:54
@wking wking merged commit 635eaf1 into ehuss:master May 13, 2018
@Nemo157 Nemo157 deleted the separate-fetcher branch May 14, 2018 07:24
wking added a commit to wking/license-exprs that referenced this pull request Jun 18, 2018
Changes since v1.3.0:

* Updated SPDX License List to 3.1 (ehuss#9, ehuss#11, ehuss#17, ehuss#19, ehuss#24)
* Updated SPDX License Expression reference from 2.0 to 2.1 (ehuss#8).
* Document our license-list version, parens issue, and license (ehuss#16,
  ehuss#17).
* Add Travis CI configuration (ehuss#22).
* Add additional test cases (ehuss#25).
* .mailmap: Consolidate authors (ehuss#26).
@wking wking mentioned this pull request Jun 18, 2018
wking added a commit to wking/license-exprs that referenced this pull request Jun 18, 2018
Changes since v1.3.0:

* Updated SPDX License List to 3.1 (ehuss#9, ehuss#11, ehuss#17, ehuss#19, ehuss#24).
* Updated SPDX License Expression reference from 2.0 to 2.1 (ehuss#8).
* Document our license-list version, parens issue, and license (ehuss#16,
  ehuss#17).
* Add Travis CI configuration (ehuss#22).
* Add additional test cases (ehuss#25).
* .mailmap: Consolidate authors (ehuss#26).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants