auto filled bug fixes

[nipunarora-eGov]

Choose the appropriate template for your PR:

• Feature PR
• Bugfix PR
• Release PR

Summary by CodeRabbit

Release Notes

• New Features

  • Enhanced formula configuration with improved validation and management of assumptions.
  • Introduced a new property, showOnEstimationDashboard, for better formula visibility control.
  • Improved state management in the HypothesisWrapper component, allowing for more complex interactions.

• Bug Fixes

  • Refined error handling and validation checks in the SetupMicroplan component to improve user feedback during updates and submissions.

• Improvements

  • Enhanced user navigation and flow within the formula configuration process, ensuring mandatory fields are validated before proceeding.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes in this pull request enhance the functionality of the formula configuration workflow by improving the management and validation of assumptions and formulas. Key modifications include the introduction of new properties and logic for handling assumptions, refining the formula insertion process, and enhancing state management in various components. The updates also include improved error handling and user feedback mechanisms during form submissions and state updates.

Changes

File	Change Summary
.../FormulaConfigWrapper.js	Added logic for assumption validation and filtering; modified useEffect hooks; improved URL parameter management.
.../FormulaConfiguration.js	Introduced showOnEstimationDashboard property; refined formula insertion and deletion management.
.../HypothesisWrapper.js	Added dispatch function for context state; improved validation in handleNext; refined handling of assumptions.
.../SetupMicroplan.js	Added dispatch for session invalidation; refined error handling and inline validations in onSubmit.

Possibly related PRs

• Mp hypothesis #1501: Enhancements to handling of assumptions in HypothesisWrapper.js, related to validation and management of assumptions.
• Formula screens rework, cascading changes on formula deletion #1682: Updates in FormulaConfigWrapper.js for managing and validating assumptions, aligning with main PR changes.
• Update dropdown options and maintaining proper order in update of formulas #1731: Modifications in FormulaConfiguration.js regarding formula insertion and order, relevant to the overall configuration process.

Suggested reviewers

• Rachana Egov
• Nabeel Md Egov

🐰 "In the meadow where formulas play,
Assumptions dance and sway,
With logic bright and clear,
We hop along without fear!
Validations strong, we cheer,
In our microplan, all is dear!" 🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 6

🧹 Outside diff range comments (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HypothesisWrapper.js (1)

Line range hint 1-400: Consider refactoring for improved maintainability

The component could benefit from the following architectural improvements:

1. Extract assumption validation logic into a custom hook to reduce duplication between handleNext and handleStepClick
2. Consider consolidating related useEffect hooks (e.g., those managing URL parameters)
3. Move the assumption transformation logic into a separate utility function

Example custom hook for assumption validation:

const useAssumptionValidation = (assumptionValues, deletedAssumptions) => {
  const validateAssumptions = (assumptions) => {
    const existingAssumptionKeys = assumptionValues.map(assumption => assumption.key);
    const visibleAssumptions = assumptions.filter(item =>
      existingAssumptionKeys?.includes(item) && !deletedAssumptions?.includes(item)
    );

    return visibleAssumptions.some(item => {
      const value = assumptionValues.find(assumption => assumption.key === item)?.value;
      return !value;
    });
  };

  return validateAssumptions;
};

This would simplify the validation logic in both handleNext and handleStepClick.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between c5f0053 and 86a1300.

📒 Files selected for processing (4)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FormulaConfigWrapper.js (2 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FormulaConfiguration.js (0 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HypothesisWrapper.js (2 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SetupMicroplan.js (1 hunks)

💤 Files with no reviewable changes (1)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FormulaConfiguration.js

🧰 Additional context used

📓 Path-based instructions (3)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FormulaConfigWrapper.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HypothesisWrapper.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SetupMicroplan.js (1)

Pattern **/*.js: check

🔇 Additional comments (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HypothesisWrapper.js (1)

19-19: LGTM: Context state management enhancement

The addition of dispatch to the context state retrieval is appropriate for managing the global state of assumptions.