chore: analytics screen events improvements and name fixes #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shafqat-muneer
approved these changes
Sep 12, 2024
rnr
approved these changes
Sep 12, 2024
saeedbashir
added a commit
that referenced
this pull request
Sep 20, 2024
rnr
pushed a commit
that referenced
this pull request
Dec 5, 2024
rnr
added a commit
that referenced
this pull request
Dec 9, 2024
* fix: video tab with youtube (#52) * fix: don't show error if only youtube videos * fix: call UI updates from main queue * fix: don't send completion at youtube video start --------- Co-authored-by: Anton Yarmolenko <[email protected]> * chore: delete unneeded MainActor instructions * feat: save playback speed (#67) * chore: save playback speed in CourseStorage * chore: add full screen for youtube on iPad * chore: save value in userdefaults * chore: little refactor * fix: fix warning * chore: added CourseStorage as injection * chore: moved playback speed to user settings --------- Co-authored-by: Anton Yarmolenko <[email protected]> * chore: analytics screen events improvements and name fixes (#76) * chore: fix tests --------- Co-authored-by: Anton Yarmolenko <[email protected]> Co-authored-by: Saeed Bashir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issues:
:like the eventPayments: Upgrade Now Clickedchanged toPayments:Upgrade Now Clicked.Jira Tickets:
Screen events sheet: https://docs.google.com/spreadsheets/d/1qf0sboa6CXGhsh76eERCJM8FpUWCUWr3MSItLuRtdNE/edit?gid=635851976#gid=635851976