feat: save playback speed #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forgotvas
requested changes
Aug 12, 2024
| @@ -84,6 +85,19 @@ public class PlayerViewControllerHolder: PlayerViewControllerHolderProtocol { | |||
| playerController.delegate = playerDelegate | |||
| playerController.player = playerTracker.player as? AVPlayer | |||
| playerController.player?.currentItem?.preferredMaximumResolution = videoResolution | |||
|
|
|||
| let storage = Container.shared.resolve(CourseStorage.self) | |||
There was a problem hiding this comment.
Please make it as injection
forgotvas
reviewed
Aug 12, 2024
| @@ -11,6 +11,7 @@ import Core | |||
| public protocol CourseStorage { | |||
| var allowedDownloadLargeFile: Bool? { get set } | |||
| var userSettings: UserSettings? { get set } | |||
| var videoPlaybackSpeed: Float? {get set} | |||
There was a problem hiding this comment.
Maybe better to move it to UserSettings where we have streamingQuality option?
There was a problem hiding this comment.
We don't have a separate setting for this at the profile/settings level. It can only be changed in the video player. I don't think we need to mix this with the settings object. Thank you
There was a problem hiding this comment.
It would be nice if we could group all the user settings regardless of their place of usage.
forgotvas
approved these changes
Aug 15, 2024
forgotvas
approved these changes
Aug 16, 2024
saeedbashir
reviewed
Aug 19, 2024
| self.pipManager = pipManager | ||
| self.playerTracker = playerTracker | ||
| self.playerService = playerService | ||
| let youtubePlayer = playerTracker.player as? YouTubePlayer | ||
| var configuration = youtubePlayer?.configuration | ||
| configuration?.autoPlay = !pipManager.isPipActive | ||
| configuration?.fullscreenMode = .web |
There was a problem hiding this comment.
@saeedbashir it's not relevant to playback speed. It adds fullscreen for iPad. Update PR description.
Thank you
saeedbashir
approved these changes
Aug 21, 2024
saeedbashir
pushed a commit
that referenced
this pull request
Aug 23, 2024
* chore: save playback speed in CourseStorage * chore: add full screen for youtube on iPad * chore: save value in userdefaults * chore: little refactor * fix: fix warning * chore: added CourseStorage as injection * chore: moved playback speed to user settings --------- Co-authored-by: Anton Yarmolenko <[email protected]>
rnr
added a commit
that referenced
this pull request
Dec 5, 2024
* chore: save playback speed in CourseStorage * chore: add full screen for youtube on iPad * chore: save value in userdefaults * chore: little refactor * fix: fix warning * chore: added CourseStorage as injection * chore: moved playback speed to user settings --------- Co-authored-by: Anton Yarmolenko <[email protected]>
rnr
added a commit
that referenced
this pull request
Dec 9, 2024
* fix: video tab with youtube (#52) * fix: don't show error if only youtube videos * fix: call UI updates from main queue * fix: don't send completion at youtube video start --------- Co-authored-by: Anton Yarmolenko <[email protected]> * chore: delete unneeded MainActor instructions * feat: save playback speed (#67) * chore: save playback speed in CourseStorage * chore: add full screen for youtube on iPad * chore: save value in userdefaults * chore: little refactor * fix: fix warning * chore: added CourseStorage as injection * chore: moved playback speed to user settings --------- Co-authored-by: Anton Yarmolenko <[email protected]> * chore: analytics screen events improvements and name fixes (#76) * chore: fix tests --------- Co-authored-by: Anton Yarmolenko <[email protected]> Co-authored-by: Saeed Bashir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds playback speed preservation for native videos. Also it adds fullscreen mode for YouTube videos for iPad
From doc
RPReplay_Final1721741975.MP4