Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SE device UI issues #39

Merged
merged 15 commits into from
Jul 26, 2024
Merged

fix: SE device UI issues #39

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
28bf8a9
fix: se device
forgotvas Jul 22, 2024
537e922
fix: course image
forgotvas Jul 22, 2024
49a42c4
fix: small course
forgotvas Jul 22, 2024
87f3a31
Merge branch '2U/develop' into fix/se
forgotvas Jul 24, 2024
4611a4b
fix: header for ios 15
forgotvas Jul 24, 2024
0d8e36d
fix: double nav bar
forgotvas Jul 24, 2024
5782e28
chore: added trophy assets
forgotvas Jul 24, 2024
f7945a9
fix: fixed all courses screen
forgotvas Jul 24, 2024
adb31ea
fix: ipad course dashboard
forgotvas Jul 24, 2024
475e004
chore: fixed dates banner padding
forgotvas Jul 25, 2024
e9a79af
fix: ipad upgrade view
forgotvas Jul 25, 2024
dab7185
chore: fix for rotation bug
forgotvas Jul 25, 2024
1adb41a
fix: scroll on home tab
forgotvas Jul 26, 2024
a8f0394
chore: update introspect for future versions
forgotvas Jul 26, 2024
0ea8c8b
chore: rename name of file icon
forgotvas Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Course/Course/Presentation/Container/CourseContainerView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ public struct CourseContainerView: View {
}
}
.versionedTabStyle()
.introspect(.scrollView, on: .iOS(.v15, .v16, .v17), customize: { tabView in
.introspect(.scrollView, on: .iOS(.v16, .v17), customize: { tabView in
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forgotvas What will happen when the new iOS version iOS 18, will be released, do we need to white list future updates or will it be handled automatically?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will need add new version or we will need to change standard introspect to @_spi(Advanced) import SwiftUIIntrospect and use it like .introspect(.scrollView, on: .iOS(.v15...), customize: { scrollView in

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update it so we don't have to worry about future updates, until unless there is an issue?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or if it's out of the scope of this PR, we can create a task for this and can handle it post-MVP.

Copy link
Collaborator Author

@forgotvas forgotvas Jul 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, also checked via search on project word .introspect and found that there no any other places where it uses list like .v(16), .v(17). Other places use certain version or relative range.

tabView.isScrollEnabled = false
})
.introspect(.viewController, on: .iOS(.v15), customize: { controller in
Expand Down
Loading