fix: SE device UI issues #39

forgotvas · 2024-07-24T09:42:16Z

Related to iOS Buggy UI openedx#511 including header view for iOS 15

Contains fixes for:

Learn Tab > Upgrade to access more features button has icon missing
Course Home > UI does not load properly. The course header is covering the content.
All Course > Buggy UI
Course dashboard > UI does not load properly. The course header is covering the content.
Course Dashboard > Expired course’s image disappears after a blink

saeedbashir

LGTM 👍

forgotvas · 2024-07-24T14:45:54Z

fixed header for iOS 15

forgotvas · 2024-07-24T15:29:17Z

Added some fixes for Bug Bash, description updated

saeedbashir · 2024-07-25T05:50:52Z

The Shift Due Date is slightly under the header, on all devices
On rotation the UI disturbs and shows UI of two tabs (only on iPhone 7 iOS 15)

Screen.Recording.2024-07-25.at.10.39.10.AM.mov

saeedbashir · 2024-07-25T07:02:24Z

@forgotvas Most of the iPad issues are fixed in this PR, but the value prop view is not rendered properly.

forgotvas · 2024-07-25T11:41:47Z

Hi @saeedbashir, i have fixed iPad and fixed Due Date top padding, for rotation bug please add note to Bug Bash. Thank you

forgotvas · 2024-07-25T15:38:51Z

@saeedbashir fixed rotation bug here too

saeedbashir · 2024-07-26T03:30:10Z

@forgotvas Scroll is disabled on Course outline (Home) tab.
https://github.com/user-attachments/assets/bebaa3da-230c-4338-b04e-86819bdccd27

forgotvas · 2024-07-26T05:22:32Z

@forgotvas Scroll is disabled on Course outline (Home) tab. https://github.com/user-attachments/assets/bebaa3da-230c-4338-b04e-86819bdccd27

fixed

saeedbashir · 2024-07-26T05:35:35Z

Course/Course/Presentation/Container/CourseContainerView.swift

@@ -316,7 +316,7 @@ public struct CourseContainerView: View {
            }
        }
        .versionedTabStyle()
-        .introspect(.scrollView, on: .iOS(.v15, .v16, .v17), customize: { tabView in
+        .introspect(.scrollView, on: .iOS(.v16, .v17), customize: { tabView in


@forgotvas What will happen when the new iOS version iOS 18, will be released, do we need to white list future updates or will it be handled automatically?

we will need add new version or we will need to change standard introspect to @_spi(Advanced) import SwiftUIIntrospect and use it like .introspect(.scrollView, on: .iOS(.v15...), customize: { scrollView in

Can you update it so we don't have to worry about future updates, until unless there is an issue?

or if it's out of the scope of this PR, we can create a task for this and can handle it post-MVP.

updated, also checked via search on project word .introspect and found that there no any other places where it uses list like .v(16), .v(17). Other places use certain version or relative range.

saeedbashir

LGTM 👍

saeedbashir · 2024-07-26T06:06:00Z

Core/Core/Assets.xcassets/trophy.imageset/Contents.json

+{
+  "images" : [
+    {
+      "filename" : "Regular-M.pdf",


Could you please change the file name to the asset name?

* fix: se device * fix: course image * fix: small course * fix: header for ios 15 * fix: double nav bar * chore: added trophy assets * fix: fixed all courses screen * fix: ipad course dashboard * chore: fixed dates banner padding * fix: ipad upgrade view * chore: fix for rotation bug * fix: scroll on home tab * chore: update introspect for future versions * chore: rename name of file icon

* fix: SE device UI issues (#39) * fix: se device * fix: course image * fix: small course * fix: header for ios 15 * fix: double nav bar * chore: added trophy assets * fix: fixed all courses screen * fix: ipad course dashboard * chore: fixed dates banner padding * fix: ipad upgrade view * chore: fix for rotation bug * fix: scroll on home tab * chore: update introspect for future versions * chore: rename name of file icon * chore: delete unneeded IAP icon * chore: delete IAP part * chore: delete IAP part * chore: fix after merge * chore: started to add courseRawImage * chore: delete IAP part * fix: after merge * chore: deleted unsupported ios 15 modifiers * chore: added courseRawImage * chore: moved progress to correct place * chore: fix broken tests --------- Co-authored-by: Vadim Kuznetsov <[email protected]> Co-authored-by: Anton Yarmolenko <[email protected]>

forgotvas added 3 commits July 22, 2024 21:18

fix: se device

28bf8a9

fix: course image

537e922

fix: small course

49a42c4

forgotvas requested review from rnr and saeedbashir July 24, 2024 09:42

Merge branch '2U/develop' into fix/se

87f3a31

saeedbashir approved these changes Jul 24, 2024

View reviewed changes

forgotvas added 2 commits July 24, 2024 17:27

fix: header for ios 15

4611a4b

fix: double nav bar

0d8e36d

forgotvas requested a review from saeedbashir July 24, 2024 14:45

forgotvas added 2 commits July 24, 2024 18:05

chore: added trophy assets

5782e28

fix: fixed all courses screen

f7945a9

fix: ipad course dashboard

adb31ea

forgotvas added 2 commits July 25, 2024 13:28

chore: fixed dates banner padding

475e004

fix: ipad upgrade view

e9a79af

rnr approved these changes Jul 25, 2024

View reviewed changes

chore: fix for rotation bug

dab7185

fix: scroll on home tab

1adb41a

saeedbashir reviewed Jul 26, 2024

View reviewed changes

chore: update introspect for future versions

a8f0394

saeedbashir approved these changes Jul 26, 2024

View reviewed changes

chore: rename name of file icon

0ea8c8b

forgotvas merged commit 1dedd69 into 2U/develop Jul 26, 2024
3 checks passed

forgotvas deleted the fix/se branch July 29, 2024 08:02

rnr mentioned this pull request Nov 7, 2024

fix: Part #4 sync to upstream openedx/openedx-app-ios#540

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: SE device UI issues #39

fix: SE device UI issues #39

forgotvas commented Jul 24, 2024 •

edited

Loading

saeedbashir left a comment

forgotvas commented Jul 24, 2024

forgotvas commented Jul 24, 2024

saeedbashir commented Jul 25, 2024

saeedbashir commented Jul 25, 2024

forgotvas commented Jul 25, 2024

forgotvas commented Jul 25, 2024

saeedbashir commented Jul 26, 2024 •

edited

Loading

forgotvas commented Jul 26, 2024

saeedbashir Jul 26, 2024

forgotvas Jul 26, 2024

saeedbashir Jul 26, 2024

saeedbashir Jul 26, 2024

forgotvas Jul 26, 2024 •

edited

Loading

saeedbashir left a comment

saeedbashir Jul 26, 2024

forgotvas Jul 26, 2024

fix: SE device UI issues #39

fix: SE device UI issues #39

Conversation

forgotvas commented Jul 24, 2024 • edited Loading

saeedbashir left a comment

Choose a reason for hiding this comment

forgotvas commented Jul 24, 2024

forgotvas commented Jul 24, 2024

saeedbashir commented Jul 25, 2024

saeedbashir commented Jul 25, 2024

forgotvas commented Jul 25, 2024

forgotvas commented Jul 25, 2024

saeedbashir commented Jul 26, 2024 • edited Loading

forgotvas commented Jul 26, 2024

saeedbashir Jul 26, 2024

Choose a reason for hiding this comment

forgotvas Jul 26, 2024

Choose a reason for hiding this comment

saeedbashir Jul 26, 2024

Choose a reason for hiding this comment

saeedbashir Jul 26, 2024

Choose a reason for hiding this comment

forgotvas Jul 26, 2024 • edited Loading

Choose a reason for hiding this comment

saeedbashir left a comment

Choose a reason for hiding this comment

saeedbashir Jul 26, 2024

Choose a reason for hiding this comment

forgotvas Jul 26, 2024

Choose a reason for hiding this comment

forgotvas commented Jul 24, 2024 •

edited

Loading

saeedbashir commented Jul 26, 2024 •

edited

Loading

forgotvas Jul 26, 2024 •

edited

Loading