Skip to content

Commit

Permalink
fix(demo): remove host headers in SMI policies
Browse files Browse the repository at this point in the history
The `:authority` header sent by the bookbuyer to the bookstore is
actually `bookstore.bookstore:14001` where the bookstore's
HTTPRouteGroup used in the manual demo specified a `host` header match
of `bookstore.bookstore`, resulting in

    "response_code_details": "route_not_found"

in the bookstore's logs for requests from the bookbuyer.

This change removes the `host` header matches all of the demo manifests.

Fixes openservicemesh#3616

Signed-off-by: Jon Huhn <[email protected]>
  • Loading branch information
nojnhuh committed Jun 23, 2021
1 parent 50d4426 commit 9d9d893
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 8 deletions.
2 changes: 0 additions & 2 deletions demo/deploy-traffic-specs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,4 @@ spec:
- name: restock-books
methods:
- POST
headers:
- host: "bookwarehouse.$BOOKWAREHOUSE_NAMESPACE"
EOF
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,9 @@ spec:
methods:
- GET
headers:
- host: "bookstore.bookstore"
- "user-agent": ".*-http-client/*.*"
- "client-app": "bookbuyer"
- name: buy-a-book
pathRegex: ".*a-book.*new"
methods:
- GET
headers:
- host: "bookstore.bookstore"
3 changes: 0 additions & 3 deletions docs/example/manifests/access/traffic-access-v1.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,9 @@ spec:
methods:
- GET
headers:
- host: "bookstore.bookstore"
- "user-agent": ".*-http-client/*.*"
- "client-app": "bookbuyer"
- name: buy-a-book
pathRegex: ".*a-book.*new"
methods:
- GET
headers:
- host: "bookstore.bookstore"

0 comments on commit 9d9d893

Please sign in to comment.