Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Demo: Bookbuyer refused by bookstore with HTTP 404 #3616

Closed
farhan7500 opened this issue Jun 17, 2021 · 0 comments · Fixed by #3644
Closed

Demo: Bookbuyer refused by bookstore with HTTP 404 #3616

farhan7500 opened this issue Jun 17, 2021 · 0 comments · Fixed by #3644
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@farhan7500
Copy link

Bug description:
The counter for books sold and books bought does not increment when the SMI policy is set after executing traffic-access-v1.yaml

OSM version:
ubuntu@ubuntu:~$ osm version Version: v0.9.0; Commit: 96498ba51205a08530b17b17d5ee0d53b005f874; Date: 2021-06-14-22:14

When enablePermissiveTrafficPolicyMode is set to true:


Fetching http://bookstore.bookstore:14001/books-bought
Request Headers: map[Client-App:[bookbuyer] User-Agent:[Go-http-client/1.1]]
Identity: bookstore-v1
Booksbought: 24
Server: envoy
Date: Thu, 17 Jun 2021 10:30:12 GMT
Status: 200 OK
MAESTRO! THIS TEST SUCCEEDED!

Fetching http://bookstore.bookstore:14001/buy-a-book/new
Request Headers: map[]
Identity: bookstore-v1
Booksbought: 25
Server: envoy
Date: Thu, 17 Jun 2021 10:30:12 GMT
Status: 200 OK
10:30AM INF BooksCountV1=21970720 component=demo file=books.go:167
MAESTRO! THIS TEST SUCCEEDED! 

When enablePermissiveTrafficPolicyMode is set to false:


Fetching http://bookstore.bookstore:14001/buy-a-book/new
Request Headers: map[]
Identity: n/a
Booksbought: n/a
Server: envoy
Date: Thu, 17 Jun 2021 10:19:48 GMT
Status: 404 Not Found
ERROR: response code for "http://bookstore.bookstore:14001/buy-a-book/new" is 404;  expected 200

Fetching http://bookstore.bookstore:14001/books-bought
Request Headers: map[Client-App:[bookbuyer] User-Agent:[Go-http-client/1.1]]
Identity: n/a
Booksbought: n/a
Server: envoy
Date: Thu, 17 Jun 2021 10:19:48 GMT
Status: 404 Not Found
ERROR: response code for "http://bookstore.bookstore:14001/books-bought" is 404;  expected 200

Affected area (please mark with X where applicable):

  • Install [ ]
  • SMI Traffic Access Policy [ ]
  • SMI Traffic Specs Policy [ ]
  • SMI Traffic Split Policy [ ]
  • Permissive Traffic Policy [ ]
  • Ingress [ ]
  • Egress [ ]
  • Envoy Control Plane [ ]
  • CLI Tool [ ]
  • Metrics [ ]
  • Certificate Management [ ]
  • Sidecar Injection [ ]
  • Logging [ ]
  • Debugging [ ]
  • Tests [ ]
  • Demo [ *]
  • CI System [ ]

Expected behavior:
The communication should begin between bookbuyer and bookstore

Steps to reproduce the bug (as precisely as possible):
https://release-v0-9.docs.openservicemesh.io/docs/getting_started/manual_demo/

How was OSM installed?:
https://release-v0-9.docs.openservicemesh.io/docs/getting_started/manual_demo/

Anything else we need to know?:

Environment: Kubernetes

  • OSM version (use osm version): v0.9.0
  • Kubernetes version (use kubectl version):
Server Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.7", GitCommit:"8ff64bd4edf690c75fcf172eeaaad21b929f3cbf", GitTreeState:"clean", BuildDate:"2021-03-15T07:51:22Z", GoVersion:"go1.15.5 BoringCrypto", Compiler:"gc", Platform:"linux/amd64"}
  • Size of cluster (number of worker nodes in the cluster): 3 workers
  • Others:
@farhan7500 farhan7500 added the kind/bug Something isn't working label Jun 17, 2021
@nojnhuh nojnhuh self-assigned this Jun 22, 2021
@nojnhuh nojnhuh added this to the v0.10.0 milestone Jun 22, 2021
shalier pushed a commit to shalier/osm that referenced this issue Jun 30, 2021
The `:authority` header sent by the bookbuyer to the bookstore is
actually `bookstore.bookstore:14001` where the bookstore's
HTTPRouteGroup used in the manual demo specified a `host` header match
of `bookstore.bookstore`, resulting in

    "response_code_details": "route_not_found"

in the bookstore's logs for requests from the bookbuyer.

This change removes the `host` header matches all of the demo manifests.

Fixes openservicemesh#3616

Signed-off-by: Jon Huhn <[email protected]>
brunoterkaly pushed a commit to brunoterkaly/osm that referenced this issue Jul 3, 2021
The `:authority` header sent by the bookbuyer to the bookstore is
actually `bookstore.bookstore:14001` where the bookstore's
HTTPRouteGroup used in the manual demo specified a `host` header match
of `bookstore.bookstore`, resulting in

    "response_code_details": "route_not_found"

in the bookstore's logs for requests from the bookbuyer.

This change removes the `host` header matches all of the demo manifests.

Fixes openservicemesh#3616

Signed-off-by: Jon Huhn <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants