Support universal libraries on macOS #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently fails to build on macos because of libpng build issues. Possible reference: pnggroup/libpng#372 |
csparker247
force-pushed
the
multiarch
branch
2 times, most recently
from
33e5375 to
c8357e3
Compare
|
I seem to have it working now. macOS multiarch appears to require an Apple Silicon host to build everything correctly, at least on the GitHub runners. Waiting to see if my libpng patch gets merged. |
|
The ability to use the official libpng source for this feature is currently waiting on two upstream PRs. In the meantime, we're going to merge this using a patched fork for the libpng reference. Issue #12 will track the status of those two PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds CMake flag
BUILD_MACOS_MULTIARCH, which compiles all dependencies as "universal libraries" (single file containing symbols forx86_64andarm64).Enabling this feature additionally requires building
libpngfrom source rather than using the built-in version from OpenCV, so this also adds the flagVCDEPS_BUILD_PNG. To maintain expected behavior, this is off by default, enabled whenBUILD_MACOS_MULTIARCH=ON, and can of course be controlled by setting the flag manually.