cli: switch back to human readable version information #776
Conversation
|
This PR depends on #772. The PR seemingly breaks CI, so I've manually cancelled the CI jobs for this PR. I'll restart them once the underlying issue is fixed. |
|
Needs to wait for #775 too, I'm afraid |
msanft
force-pushed
the
msanft/runtime-handler-naming
branch
5 times, most recently
from
6e40ff8 to
80685d3
Compare
Freax13
force-pushed
the
tom/pretty-version
branch
from
aaef24e to
131e659
Compare
msanft
force-pushed
the
msanft/runtime-handler-naming
branch
from
80685d3 to
81b98be
Compare
|
I think this needs a rebase |
Freax13
force-pushed
the
tom/pretty-version
branch
from
131e659 to
3f7740c
Compare
cli/main.go
Outdated
| case platforms.AKSCloudHypervisorSNP: | ||
| fmt.Fprintf(versionsWriter, "\tlaunch digest:\t%s\n", embeddedReferenceValues.AKS.TrustedMeasurement.String()) | ||
| fmt.Fprint(versionsWriter, "\tdefault SNP TCB:\t\n") | ||
| fmt.Fprintf(versionsWriter, "\t bootloader:\t%d\n", embeddedReferenceValues.AKS.SNP.MinimumTCB.BootloaderVersion.UInt8()) |
There was a problem hiding this comment.
| fmt.Fprintf(versionsWriter, "\t bootloader:\t%d\n", embeddedReferenceValues.AKS.SNP.MinimumTCB.BootloaderVersion.UInt8()) | |
| fmt.Fprintf(versionsWriter, "\t\tbootloader:\t%d\n", embeddedReferenceValues.AKS.SNP.MinimumTCB.BootloaderVersion.UInt8()) |
nit
There was a problem hiding this comment.
tabwriter does weird things if we use another tab:
There was a problem hiding this comment.
Hm.. This seems like it's intended? (for aligning everything)
There was a problem hiding this comment.
Instead of handcrafting this output, can we maybe switch to a structured format that has opinionated rendering but decent readability, e.g. YAML or TOML?
There was a problem hiding this comment.
Fine for me, if it contains the needed info.
There was a problem hiding this comment.
Yeah, tabwriter is doing what's it's supposed to to, but the behavior just doesn't fit our use-case.
There was a problem hiding this comment.
Fine for me, if it contains the needed info.
The embedded reference values don't contain the genpolicy version.
There was a problem hiding this comment.
@burgerdev @katexochen are you fine with hand-crafting the ouput for now? Maybe once we only use a single genpolicy version, we can just print the reference values verbatim.
msanft
force-pushed
the
msanft/runtime-handler-naming
branch
6 times, most recently
from
2cc8939 to
0eb46f1
Compare
|
needs another rebase, sorry. Changes LGTM though. |
Freax13
force-pushed
the
tom/pretty-version
branch
from
3f7740c to
89f300b
Compare
Freax13
force-pushed
the
tom/pretty-version
branch
2 times, most recently
from
344c43a to
e1ce818
Compare
Freax13
force-pushed
the
tom/pretty-version
branch
from
e1ce818 to
b6cb256
Compare
This PR changes the JSON dump back into a human readable version dump :)