Share Go module between node-installer and contrast #775
Conversation
internal/platforms/platforms.go
Outdated
There was a problem hiding this comment.
I don't quite get why this is needed - it looks like we've been using github.com/edgelesssys/contrast/node-installer/platforms in the CLI before, so why can't we do this anymore with the runtime handler calculation?
There was a problem hiding this comment.
Since the runtime handler calculation depends on the embedded reference values (as they include the hashes of the runtime components).
This would require us to inject the reference values into both the node-installer and the main module, also requiring code duplication for the calculation.
We could also move the reference values (and the embedding) into the node-installer entirely, but that felt out-of-place, since the main usage of these happens in the manifest. But if you see an advantage in doing so, I'm happy to adjust.
There was a problem hiding this comment.
But then we still need to duplicate the asset injection, don't we?
There was a problem hiding this comment.
As far as I could image now, we'd only need to inject into the node-installer then?
There was a problem hiding this comment.
We still need to pass the linker flags to both binaries, but we don't need to pass two linker flags for the same version in different modules. We could also declare the linker flags in a single place and reuse that for all relevant binaries.
msanft
force-pushed
the
msanft/share-package
branch
4 times, most recently
from
43cca7e to
e7978c1
Compare
Since the Contrast main package (i.e. cli, etc.) will need to share a significant portion of code to enable runtime-handler calculation for both, we transition to using the top-level module for the node-installer to enable imports of the internal packages of the Contrast main module. Alternative options considered included code-sharing, which would introduce many duplications accross node-installer and main module, and would have required a duplicated injection of the reference values, and thus was considered infeasible. Another solution tried consisted of moving the platforms package to a top-level exported package in the main module, but since that node-installer is a child of the main module too, a replace tag does not work in this case, as the node-installer in `github.com/edgelesssys/contrast/node-installer` is unable to use a replacement for `github.com/edgelesssys/contrast`.
msanft
force-pushed
the
msanft/share-package
branch
from
e7978c1 to
9d69ee5
Compare
Since the Contrast main package (i.e. cli, etc.) will need to share a significant portion of code to enable runtime-handler calculation for both, we transition to using the top-level module for the node-installer to enable imports of the internal packages of the Contrast main module.
Alternative options considered included code-sharing, which would introduce many duplications accross node-installer and main module, and would have required a duplicated injection of the reference values, and thus was considered infeasible. Another solution tried consisted of moving the platforms package to a top-level exported package in the main module, but since that node-installer is a child of the main module too, a replace tag does not work in this case, as the node-installer in
github.com/edgelesssys/contrast/node-installeris unable to use a replacement forgithub.aaakk.us.kg/edgelesssys/contrast.