-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initializer: add cryptsetup subcommand #1153
Merged
Merged
+216
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgerdev
reviewed
Jan 15, 2025
jmxnzo
force-pushed
the
initializer/cryptsetup-integration-jla
branch
2 times, most recently
from
January 15, 2025 15:41
845c276
to
a715e67
Compare
jmxnzo
force-pushed
the
initializer/cryptsetup-integration-jla
branch
4 times, most recently
from
January 16, 2025 15:29
b17526d
to
c982c25
Compare
jmxnzo
force-pushed
the
cryptsetup/initializer/rework-bash
branch
4 times, most recently
from
January 16, 2025 15:48
5e7c79c
to
ec4f47e
Compare
jmxnzo
force-pushed
the
initializer/cryptsetup-integration-jla
branch
from
January 16, 2025 15:54
c982c25
to
f28e6c8
Compare
jmxnzo
force-pushed
the
cryptsetup/initializer/rework-bash
branch
from
January 20, 2025 09:12
ec4f47e
to
c176341
Compare
jmxnzo
force-pushed
the
initializer/cryptsetup-integration-jla
branch
from
January 20, 2025 09:17
f28e6c8
to
957cc7f
Compare
jmxnzo
force-pushed
the
cryptsetup/initializer/rework-bash
branch
3 times, most recently
from
January 21, 2025 07:35
b0f9a62
to
7253c27
Compare
jmxnzo
force-pushed
the
initializer/cryptsetup-integration-jla
branch
from
January 21, 2025 08:13
957cc7f
to
0ff8c32
Compare
jmxnzo
force-pushed
the
cryptsetup/initializer/rework-bash
branch
2 times, most recently
from
January 21, 2025 11:58
01c9cfb
to
c9f2576
Compare
jmxnzo
force-pushed
the
initializer/cryptsetup-integration-jla
branch
2 times, most recently
from
January 21, 2025 12:17
1bbc7e2
to
a6c11ec
Compare
jmxnzo
changed the title
initializer/cryptsetup: add option to setupEncryptedMount
initializer: add setupEncryptedMount subcommand
Jan 23, 2025
burgerdev
reviewed
Jan 23, 2025
jmxnzo
force-pushed
the
initializer/cryptsetup-integration-jla
branch
from
January 24, 2025 14:33
a42d754
to
78b8457
Compare
jmxnzo
changed the title
initializer: add setupEncryptedMount subcommand
initializer: add cryptsetup subcommand
Jan 24, 2025
jmxnzo
force-pushed
the
initializer/cryptsetup-integration-jla
branch
2 times, most recently
from
January 24, 2025 14:56
2aa561d
to
0ad0b12
Compare
burgerdev
reviewed
Jan 24, 2025
jmxnzo
force-pushed
the
initializer/cryptsetup-integration-jla
branch
from
January 27, 2025 08:59
0ad0b12
to
20a409d
Compare
3u13r
previously requested changes
Jan 27, 2025
jmxnzo
force-pushed
the
initializer/cryptsetup-integration-jla
branch
4 times, most recently
from
January 27, 2025 10:47
1bbe4a0
to
2439efa
Compare
|
jmxnzo
force-pushed
the
initializer/cryptsetup-integration-jla
branch
2 times, most recently
from
January 27, 2025 11:05
82299c7
to
1e96856
Compare
jmxnzo
force-pushed
the
initializer/cryptsetup-integration-jla
branch
from
January 27, 2025 11:28
1e96856
to
87c3bfd
Compare
burgerdev
reviewed
Jan 27, 2025
jmxnzo
force-pushed
the
initializer/cryptsetup-integration-jla
branch
2 times, most recently
from
January 27, 2025 15:02
f550c48
to
195a55f
Compare
jmxnzo
force-pushed
the
initializer/cryptsetup-integration-jla
branch
from
January 28, 2025 10:38
a69da93
to
1573898
Compare
burgerdev
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR translates the bash entrypoint currently used for setting up an encrypted volume with cryptsetup to a
cryptsetup
subcommand in the initializer binary, which takes the device path and the required mount point as flags.cryptsetup
Cobra subcommand to the initializer command, wrapping the setupEncryptedMount function -- follow-up on initializer: add Cobra for subcommands #1157The shared code of mounting mechanisms between the coordinator and initializer was moved to internal/mount in #1163 .
e2e volumestatefulset: https://github.com/edgelesssys/contrast/actions/runs/13008716710/job/36281340998