-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initializer/cryptsetup: rework bash entrypoint #1140
Conversation
8c985ab
to
5ad4898
Compare
06f59f8
to
eddd6bc
Compare
5e7c79c
to
ec4f47e
Compare
7a57a5c
to
492ee9b
Compare
ec4f47e
to
c176341
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but I'd like to get a second opinion from @3u13r.
7253c27
to
01c9cfb
Compare
As described in Figure 4: pseudo code for key creation each PBKDF2 derived encryption key used to encrypt the AFSplit of the master key, is derived by the passphrase and a 32 byte salt from a random source. |
01c9cfb
to
c9f2576
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c9f2576
to
b6eb084
Compare
Similarly to #1161 , this PR serves as a preliminary step toward moving cryptsetup to a subcommand of the initializer binary. Before translating the Bash entrypoint (used in the initializer binary after merging #1161) into Go code, the script was reworked to allow a cleaner integration of the volume encryption.
There were a few peculiarities in the cryptsetup LUKS standardization that have not been fully addressed in the current version of the entrypoint:
--key-file
flag with cryptsetup, the file's contents are unexpectedly treated as a passphrase rather than a cryptographic key.e2e/volumestatefulset: https://github.com/edgelesssys/contrast/actions/runs/12764474415/job/35576714135