[release/v1.2] cli: make default WorkloadSecretIDs unique per k8s object #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 399ac4b)
katexochen
changed the title
|
I was not paying enough attention while cherry-picking: backporting the test requires #1104. I'll just remove the test then. |
(cherry picked from commit 59cacc3)
burgerdev
force-pushed
the
backport-1127-to-release/v1.2
branch
from
c0889b3 to
f737d0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1127 to
release/v1.2.Original description:
Contrast configures the manifest with a default
WorkloadSecretIDper k8s object. The current default is simply the object name, which can be problematic if multiple objects (e.g. different kinds) share a name.Combining the default workload secret ID from group, version, kind, namespace and name should ensure different k8s objects get different workload secrets.