cli: make default WorkloadSecretIDs unique per k8s object #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgerdev
force-pushed
the
burgerdev/secrets
branch
from
a8048b9 to
d9821e3
Compare
burgerdev
added
no changelog
burgerdev
force-pushed
the
burgerdev/secrets
branch
from
d9821e3 to
0f95331
Compare
burgerdev
changed the title
burgerdev
added
bug fix
katexochen
approved these changes
Jan 9, 2025
burgerdev
force-pushed
the
burgerdev/secrets
branch
from
0e422f5 to
540b159
Compare
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/v1.2
git worktree add -d .worktree/backport-1127-to-release/v1.2 origin/release/v1.2
cd .worktree/backport-1127-to-release/v1.2
git switch --create backport-1127-to-release/v1.2
git cherry-pick -x 399ac4bc47adb8655595847ae246ea50a2cc12d7 59cacc33bfa24576604d71b8d3de819b0bba82be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrast configures the manifest with a default
WorkloadSecretIDper k8s object. The current default is simply the object name, which can be problematic if multiple objects (e.g. different kinds) share a name.Combining the default workload secret ID from group, version, kind, namespace and name should ensure different k8s objects get different workload secrets.