-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add readOnly functionality to array and list #2040
Conversation
ea279ac
to
dbe4e3f
Compare
@LukasBoll With this PR readOnly arrays don't even show their action buttons. Alternatively we could still show them but disable them. What do prefer personally? |
There are two cases:
Overall, I would not show the action buttons, since 1) is probably the basic case and it is misleading for the user if buttons without functionality are shown. |
@lucas-koehler With this PR readOnly arrays don't even show their action buttons. Alternatively we could still show them but disable them. What do prefer personally? |
@sdirix Ideally,we would support both cases described by @LukasBoll :
The reason is that I would expect a disabled button to have the possibility to get enabled. If supporting both is not feasible, I tend to agree with @LukasBoll to not show them to not confuse users in the first case. |
@LukasBoll please rebase or merge in the master branch. The files were moved. |
dbe4e3f
to
aee81cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aee81cd
to
75c6402
Compare
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me!
closes #1901