readonly and arrays

[baerry]

Describe the bug

When having a schema with an array as toplevel, and you give Jsonforms readonly, it renders all inputs on the array object readonly, which is expected, but the buttons for adding new row or removing row is still enabled, ive tried to search if its intentional, and if you can remove/disale them when the Jsonform is set to readonly without much success.

Expected behavior

Since the whole controller is set to readonly, i expect to not being able to add and remove rows from an array.

Steps to reproduce the issue

Create a schema with an array as toplevel, give it a few inputs, mock some rows with data, set the jsonforms controller to readonly, click on add / remove on a row,

Screenshots

clicking on add gives a new row, and since the properties are readonly on the new row, it feels like a bug? and adding a new row should be disabled?

In which browser are you experiencing the issue?

Google Chrome Version 119.0.6045.123 (Officiell version) (64 bit)

Which Version of JSON Forms are you using?

v3.1.0

Framework

React

RendererSet

Material

Additional context

No response

[sdirix]

Hi @baerry,

Thanks for the report! We don't intend to render the modification buttons when the control is disabled.

I think the issue should already be fixed via PR #2040. Can you try the latest next version of JSON Forms, i.e. 3.2.0-alpha.3 and report whether the issue still occurs?

[baerry]

@sdirix

I tried it in the 3.2.0-alpha.3, and it works, thanks :) , is there any planned release date for 3.2?

[sdirix]

Hi @baerry, We don't have an announced date. However we plan to release still within 2023 if nothing unexpected comes up.

[sdirix]

Closing this issue now ;)

[leixuexxxx]

Still an issue in vanilla-renderers.

[sdirix]

Still an issue in vanilla-renderers.

Hi @leixuexxxx,

Feel free to open a new issue for them. Thanks!