Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set required mzML defaultArrayLength #855

Merged
merged 3 commits into from
Dec 18, 2021

Conversation

Mailaender
Copy link
Contributor

This is a followup to #852.

@bspratt
Copy link

bspratt commented Dec 16, 2021

Those changes look promising - can you re-run that conversion and send me a link to the result?

@Mailaender
Copy link
Contributor Author

@bspratt
Copy link

bspratt commented Dec 16, 2021

Looks good - I can view it in SeeMS with my patch for tolerating zero length scans (that should show up in tomorrow's release at https://proteowizard.sourceforge.io/download.html).

Ideally you would also populate each scan's base peak m/z, base peak intensity, and total ion current, e.g.

      <cvParam cvRef="MS" accession="MS:1000505" name="base peak intensity" value="1196.0" unitCvRef="MS" unitAccession="MS:1000131" unitName="number of detector counts"/>
      <cvParam cvRef="MS" accession="MS:1000504" name="base peak m/z" value="328.049513705619" unitCvRef="MS" unitAccession="MS:1000040" unitName="m/z"/>
      <cvParam cvRef="MS" accession="MS:1000285" name="total ion current" value="9941.0" unitCvRef="MS" unitAccession="MS:1000131" unitName="number of detector counts"/>

Also setting the spectrum type is good practice, e.g.

      <cvParam cvRef cvRef="MS" accession="MS:1000579" name="MS1 spectrum" value=""/>

or, where mslevel is greater than 1,

    <cvParam cvRef="MS" accession="MS:1000580" name="MSn spectrum" value=""/>

@Mailaender Mailaender force-pushed the mzml-default-array-length branch from f8b4251 to 2b9002f Compare December 16, 2021 21:47
@Mailaender
Copy link
Contributor Author

Updated.

@bspratt
Copy link

bspratt commented Dec 16, 2021

These changes look good. Can you post another converter output file?

@Mailaender Mailaender force-pushed the mzml-default-array-length branch from 2b9002f to 216b026 Compare December 17, 2021 09:18
@Mailaender
Copy link
Contributor Author

https://share.lablicate.com/index.php/s/Q5TNSRDQfMm4Ffc

Note that this increases file size by ~ 40 %.

@bspratt
Copy link

bspratt commented Dec 17, 2021

Looks great!

Note that this increases file size by ~ 40 %.

Yes, mzML is terribly verbose.

@eselmeister eselmeister merged commit ec1007e into eclipse:develop Dec 18, 2021
@Mailaender Mailaender deleted the mzml-default-array-length branch December 18, 2021 10:54
@Mailaender
Copy link
Contributor Author

https://github.com/OpenChrom/openchrom/wiki/Changelog#202112230244 a new version containing this fix has been released. Happy holidays. 🎄

@bspratt
Copy link

bspratt commented Dec 23, 2021

Echt gut. Fröhliche Weihnachtszeit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants