-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set required mzML defaultArrayLength #855
Set required mzML defaultArrayLength #855
Conversation
Those changes look promising - can you re-run that conversion and send me a link to the result? |
Looks good - I can view it in SeeMS with my patch for tolerating zero length scans (that should show up in tomorrow's release at https://proteowizard.sourceforge.io/download.html). Ideally you would also populate each scan's base peak m/z, base peak intensity, and total ion current, e.g.
Also setting the spectrum type is good practice, e.g.
or, where mslevel is greater than 1,
|
f8b4251
to
2b9002f
Compare
Updated. |
These changes look good. Can you post another converter output file? |
2b9002f
to
216b026
Compare
https://share.lablicate.com/index.php/s/Q5TNSRDQfMm4Ffc Note that this increases file size by ~ 40 %. |
Looks great!
Yes, mzML is terribly verbose. |
https://github.com/OpenChrom/openchrom/wiki/Changelog#202112230244 a new version containing this fix has been released. Happy holidays. 🎄 |
Echt gut. Fröhliche Weihnachtszeit! |
This is a followup to #852.