Fixed mzML array length compatiblity problems #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mailaender
force-pushed
the
mz-array-length
branch
from
ec981f2 to
ce71ebc
Compare
when there is already defaultArrayLength.
Mailaender
force-pushed
the
mz-array-length
branch
from
ce71ebc to
3c5f1d3
Compare
|
Can you send me your latest conversion output for testing? Thanks. I feel we are very close to making this work (though from my reading of your changes it looks like maybe you are not setting the defaultArrayLength value?). |
|
Sorry, I misunderstood and thought the example file was generated using OpenChrom and that was already set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the issues raised in OpenChrom/openchrom#175 (comment)