Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added auto detection to .mzXML files #658

Merged
merged 3 commits into from
Jun 28, 2021
Merged

Added auto detection to .mzXML files #658

merged 3 commits into from
Jun 28, 2021

Conversation

Mailaender
Copy link
Contributor

This is a followup of #534 which brings it in line with the other recent XML file formats

@eselmeister
Copy link
Contributor

Please have a look at the comment. Principally, it looks good, but having a deep look at the *.xml content could lead to performance issues. But I don't see any other way to precisely check the file.

@Mailaender
Copy link
Contributor Author

Yes, I also felt bad about it, so I added #655 to investigate. Rebased and the cost is 4 ms per file on local SSD:

INFO main converter.AbstractSupplierFileIdentifier.isMatchMagicNumber (AbstractSupplierFileIdentifier.java:173) Magic number check of mabr_eqa20qty_0006_2L1.mzXML by mzXML Chromatogram (.mzXML) took 0.002 seconds.
INFO main converter.AbstractSupplierFileIdentifier.isMatchMagicNumber (AbstractSupplierFileIdentifier.java:173) Magic number check of mabr_eqa20qty_0006_2L1.mzXML by mzXML Mass Spectra (.mzXML) took 0.002 seconds.

which is noticeable when loading folders with >100 files e.g. https://osf.io/d6hzx/

@eselmeister eselmeister merged commit 42a8d80 into eclipse:develop Jun 28, 2021
@Mailaender Mailaender deleted the mzxml-auto-detect branch June 28, 2021 07:10
@Mailaender Mailaender mentioned this pull request Jul 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eselmeister eselmeister eselmeister left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mailaender @eselmeister